From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753514AbdKIRPm (ORCPT ); Thu, 9 Nov 2017 12:15:42 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42732 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752627AbdKIRPI (ORCPT ); Thu, 9 Nov 2017 12:15:08 -0500 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20171019233105.5ladqpdf2me36j7q@ast-mbp> References: <20171019233105.5ladqpdf2me36j7q@ast-mbp> <20171019221829.7m5nczg3ltqmhzom@ast-mbp> <150842463163.7923.11081723749106843698.stgit@warthog.procyon.org.uk> <150842476953.7923.18174368926573855810.stgit@warthog.procyon.org.uk> <482.1508453314@warthog.procyon.org.uk> To: Alexei Starovoitov Cc: dhowells@redhat.com, jlee@suse.com, linux-security-module@vger.kernel.org, gnomes@lxorguk.ukuu.org.uk, linux-efi@vger.kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, jforbes@redhat.com, Daniel Borkmann , "David S. Miller" , netdev@vger.kernel.org Subject: Re: [PATCH 18/27] bpf: Restrict kernel image access functions when the kernel is locked down MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <13471.1510247704.1@warthog.procyon.org.uk> Date: Thu, 09 Nov 2017 17:15:04 +0000 Message-ID: <13472.1510247704@warthog.procyon.org.uk> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Thu, 09 Nov 2017 17:15:08 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Alexei Starovoitov wrote: > > TBH, I've no idea how bpf does anything, so I can't say whether this is > > better, overkill or insufficient. > > ok. To make it clear: > Nacked-by: Alexei Starovoitov > For the current patch. > Unnecessary checks for no good reason in performance critical > functions are not acceptable. They aren't unnecessary checks. Can you please suggest if there's some way more suitable than just killing bpf entirely? I don't know the code, and I presume you do. David From mboxrd@z Thu Jan 1 00:00:00 1970 From: dhowells@redhat.com (David Howells) Date: Thu, 09 Nov 2017 17:15:04 +0000 Subject: [PATCH 18/27] bpf: Restrict kernel image access functions when the kernel is locked down In-Reply-To: <20171019233105.5ladqpdf2me36j7q@ast-mbp> References: <20171019233105.5ladqpdf2me36j7q@ast-mbp> <20171019221829.7m5nczg3ltqmhzom@ast-mbp> <150842463163.7923.11081723749106843698.stgit@warthog.procyon.org.uk> <150842476953.7923.18174368926573855810.stgit@warthog.procyon.org.uk> <482.1508453314@warthog.procyon.org.uk> Message-ID: <13472.1510247704@warthog.procyon.org.uk> To: linux-security-module@vger.kernel.org List-Id: linux-security-module.vger.kernel.org Alexei Starovoitov wrote: > > TBH, I've no idea how bpf does anything, so I can't say whether this is > > better, overkill or insufficient. > > ok. To make it clear: > Nacked-by: Alexei Starovoitov > For the current patch. > Unnecessary checks for no good reason in performance critical > functions are not acceptable. They aren't unnecessary checks. Can you please suggest if there's some way more suitable than just killing bpf entirely? I don't know the code, and I presume you do. David -- To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html