From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <1347954231.10756.0.camel@aeonflux> Subject: Re: [PATCHv5 02/17] Bluetooth: A2MP: Create amp_mgr global list From: Marcel Holtmann To: Andrei Emeltchenko Cc: linux-bluetooth@vger.kernel.org, mathewm@codeaurora.org, gustavo@padovan.org Date: Tue, 18 Sep 2012 09:43:51 +0200 In-Reply-To: <1347888274-30779-3-git-send-email-Andrei.Emeltchenko.news@gmail.com> References: <1347437192-24694-1-git-send-email-Andrei.Emeltchenko.news@gmail.com> <1347888274-30779-1-git-send-email-Andrei.Emeltchenko.news@gmail.com> <1347888274-30779-3-git-send-email-Andrei.Emeltchenko.news@gmail.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi Andrei, > Create amp_mgr_list global list which will be used by different > hci devices to find amp_mgr. > > Signed-off-by: Andrei Emeltchenko > --- > include/net/bluetooth/a2mp.h | 8 ++++++++ > net/bluetooth/a2mp.c | 29 +++++++++++++++++++++++++++++ > 2 files changed, 37 insertions(+) > > diff --git a/include/net/bluetooth/a2mp.h b/include/net/bluetooth/a2mp.h > index 6a76e0a..e56d656 100644 > --- a/include/net/bluetooth/a2mp.h > +++ b/include/net/bluetooth/a2mp.h > @@ -20,11 +20,15 @@ > #define A2MP_FEAT_EXT 0x8000 > > struct amp_mgr { > + struct list_head list; > struct l2cap_conn *l2cap_conn; > struct l2cap_chan *a2mp_chan; > struct kref kref; > __u8 ident; > __u8 handle; > + enum { > + READ_LOC_AMP_INFO, > + } state; I am not a huge fan of these things. Wouldn't it be better to define the states externally properly. Regards Marcel