Re: Problem with verify-ing patch (error: arch/m68k/Kconfig.cpu: patch does not apply)

From: Artem Bityutskiy <dedekind1@gmail.com>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: linux-mtd@lists.infradead.org
Subject: Re: Problem with verify-ing patch (error: arch/m68k/Kconfig.cpu: patch does not apply)
Date: Tue, 25 Sep 2012 15:06:25 +0300	[thread overview]
Message-ID: <1348574785.20474.15.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <CACna6ryu06qsgX99kdkeDaB+XJv4XwC0-O+5ysNFa1iOMEgNow@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2544 bytes --]

On Tue, 2012-09-25 at 11:33 +0200, Rafał Miłecki wrote:
> 2012/9/24 Artem Bityutskiy <dedekind1@gmail.com>:
> > On Mon, 2012-09-24 at 13:14 +0200, Rafał Miłecki wrote:
> >> I wanted to verify my patch before sending it.
> >>
> >> TRY[0]:
> >> > ./verify ../wireless-testing/ mips-bcm47xx_defconfig < ../nand4/0001-mtd-prepare-place-for-BCMA-NAND-flash-driver-s.patch
> >> error: patch failed: arch/m68k/Kconfig.cpu:28
> >> error: arch/m68k/Kconfig.cpu: patch does not apply
> >>
> >> Weird. My patch doesn't touch m68k and applies cleanly to the
> >> ../wireless-testing tree:
> >>
> >> > cd ../wireless-testing/
> >> > git am ../nand4/0001-mtd-prepare-place-for-BCMA-NAND-flash-driver-s.patch
> >> Applying: mtd: prepare place for BCMA NAND flash driver(s)
> >>
> >> Help? :|
> >
> > It tries to apply quick fixes - I carry them because the kernel gets
> > broken in various places all the time. So you need to fix the quick
> > fixes patch - probably a fix was applied in upstream already.
> >
> > Obviously, quick fixes are in maintaining.git, not in the generic aiaiai
> > tools. They are in 'quick_fixes.mbox'.
> >
> > In this case it easy - the m68k patch get merged upstream and just can
> > be dropped from quick_fixes.mbox. Just done that and pushed out.
> 
> Thanks. Unfortunately I'm still having problems with verify/aiaiai :|
> 
> After your change I started verify again and it took 3 minutes to let
> me know it needs mips-linux-gcc. I had to install it (OpenWRT is using
> it's own toolchain).
> 
> Then I started again and after 3 minutes: lacking sparse
> 
> 3 minutes later: lacking smatch
> 
> 3 minutes later: lacking cppcheck
> 
> 3 minutes later: lacking spatch
> 
> I'm not sure what's going to be next. I'm sure that things are obvious
> for you, but beginner can really get irritated before he manages to
> setup everything... ;/

Rafal, your complaints are fair, thanks. This needs some more work. I'll
add checks for all the required tools in the scripts so that they will
fail right away with a user-friendly messages.

But one thing is obvious for me - you did not read the docs in aiaiai
projects. Well, fair enough, typical users do not read docs :-) The docs
tell where to get tools, how to compile, etc. I think they also tell
where to download pre-build compilers even, but I should check this
part :-)

I'll do the fixes as soon as I have some time, please, keep bugging me
and thanks for your feed-back!

-- 
Best Regards,
Artem Bityutskiy

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]