From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751209AbeFBBR2 (ORCPT ); Fri, 1 Jun 2018 21:17:28 -0400 Received: from mail.efficios.com ([167.114.142.138]:32894 "EHLO mail.efficios.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750758AbeFBBRZ (ORCPT ); Fri, 1 Jun 2018 21:17:25 -0400 DKIM-Filter: OpenDKIM Filter v2.10.3 mail.efficios.com 5993F2262C8 Date: Fri, 1 Jun 2018 21:17:24 -0400 (EDT) From: Mathieu Desnoyers To: "Joel Fernandes, Google" Cc: Joel Fernandes , linux-kernel , kernel-team , Boqun Feng , Byungchul Park , Erick Reyes , Ingo Molnar , Julia Cartwright , linux-kselftest , Masami Hiramatsu , Namhyung Kim , "Paul E. McKenney" , Peter Zijlstra , shuah , rostedt , Thomas Gleixner , Todd Kjos , Tom Zanussi Message-ID: <1349580221.4426.1527902244184.JavaMail.zimbra@efficios.com> In-Reply-To: <20180531175153.GA129415@joelaf.mtv.corp.google.com> References: <20180530000500.257225-1-joel@joelfernandes.org> <20180530000500.257225-6-joel@joelfernandes.org> <214539705.3633.1527749441133.JavaMail.zimbra@efficios.com> <20180531175153.GA129415@joelaf.mtv.corp.google.com> Subject: Re: [PATCH v8 5/8] tracepoint: Make rcuidle tracepoint callers use SRCU MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [167.114.142.138] X-Mailer: Zimbra 8.8.8_GA_2096 (ZimbraWebClient - FF52 (Linux)/8.8.8_GA_1703) Thread-Topic: tracepoint: Make rcuidle tracepoint callers use SRCU Thread-Index: S3anSCqc8LuW6U6wpVQUjzDowSukxA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ----- On May 31, 2018, at 1:51 PM, Joel Fernandes, Google joel@joelfernandes.org wrote: >> I find it odd to have a "return" in a macro that consists of a >> do { } while (0). I'm tempted to replace "return" by "break" here, >> to break the macro do/while (0) loop. > > "return;" is also used from "if (!(cond))" above so I prefer be consistent > and just use return than break as done above, but please let me know if you > still object. It's fine by me, Thanks! Mathieu -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: mathieu.desnoyers at efficios.com (Mathieu Desnoyers) Date: Fri, 1 Jun 2018 21:17:24 -0400 (EDT) Subject: [PATCH v8 5/8] tracepoint: Make rcuidle tracepoint callers use SRCU In-Reply-To: <20180531175153.GA129415@joelaf.mtv.corp.google.com> References: <20180530000500.257225-1-joel@joelfernandes.org> <20180530000500.257225-6-joel@joelfernandes.org> <214539705.3633.1527749441133.JavaMail.zimbra@efficios.com> <20180531175153.GA129415@joelaf.mtv.corp.google.com> Message-ID: <1349580221.4426.1527902244184.JavaMail.zimbra@efficios.com> ----- On May 31, 2018, at 1:51 PM, Joel Fernandes, Google joel at joelfernandes.org wrote: >> I find it odd to have a "return" in a macro that consists of a >> do { } while (0). I'm tempted to replace "return" by "break" here, >> to break the macro do/while (0) loop. > > "return;" is also used from "if (!(cond))" above so I prefer be consistent > and just use return than break as done above, but please let me know if you > still object. It's fine by me, Thanks! Mathieu -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: mathieu.desnoyers@efficios.com (Mathieu Desnoyers) Date: Fri, 1 Jun 2018 21:17:24 -0400 (EDT) Subject: [PATCH v8 5/8] tracepoint: Make rcuidle tracepoint callers use SRCU In-Reply-To: <20180531175153.GA129415@joelaf.mtv.corp.google.com> References: <20180530000500.257225-1-joel@joelfernandes.org> <20180530000500.257225-6-joel@joelfernandes.org> <214539705.3633.1527749441133.JavaMail.zimbra@efficios.com> <20180531175153.GA129415@joelaf.mtv.corp.google.com> Message-ID: <1349580221.4426.1527902244184.JavaMail.zimbra@efficios.com> Content-Type: text/plain; charset="UTF-8" Message-ID: <20180602011724.M_o-zuHwqHWfU8YBXwfGYya7W9nNw3ny2F-oJ4UIG0g@z> ----- On May 31, 2018,@1:51 PM, Joel Fernandes, Google joel@joelfernandes.org wrote: >> I find it odd to have a "return" in a macro that consists of a >> do { } while (0). I'm tempted to replace "return" by "break" here, >> to break the macro do/while (0) loop. > > "return;" is also used from "if (!(cond))" above so I prefer be consistent > and just use return than break as done above, but please let me know if you > still object. It's fine by me, Thanks! Mathieu -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html