From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46405) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TLiRC-0003n8-SG for qemu-devel@nongnu.org; Tue, 09 Oct 2012 18:38:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TLiRC-0006tt-13 for qemu-devel@nongnu.org; Tue, 09 Oct 2012 18:38:06 -0400 Date: Tue, 9 Oct 2012 17:37:56 -0500 From: Scott Wood References: <1349806750-17652-1-git-send-email-Bharat.Bhushan@freescale.com> <1349806750-17652-3-git-send-email-Bharat.Bhushan@freescale.com> In-Reply-To: <1349806750-17652-3-git-send-email-Bharat.Bhushan@freescale.com> (from r65777@freescale.com on Tue Oct 9 13:19:10 2012) Message-ID: <1349822276.26044.14@snotra> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; delsp=Yes; format=Flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 2/2 v2] Adding BAR0 for e500 PCI controller List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bharat Bhushan Cc: Bharat Bhushan , qemu-ppc@nongnu.org, qemu-devel@nongnu.org, afaerber@suse.de, agraf@suse.de On 10/09/2012 01:19:10 PM, Bharat Bhushan wrote: > +static int e500_ccsr_initfn(SysBusDevice *dev) > +{ > + PPCE500CCSRState *pci_ccsr; > + > + pci_ccsr =3D CCSR(dev); > + memory_region_init(&pci_ccsr->ccsr_space, "e500-ccsr", > + MPC8544_CCSRBAR_SIZE); > + return 0; > +} Is this object supposed to represent CCSR (which is what the type name =20 seems to imply, along with the existence of a different =20 PPCE500PCIBridgeState) or PCI BAR0 (which is what pci_ccsr seems to =20 imply, along with the fact that it's being added in the PCI patch)? -Scott=