Hello Daniel, On Tue, 2012-10-09 at 14:31 -0400, Daniel De Graaf wrote: > Ian Campbell wrote: > [...] > >>> +++ b/xen/xsm/flask/include/av_perm_to_string.h > > Also, in that case why is this file checked in? > > This patch fixes the autogenerated files, but doesn't fully wire them in > to things like "make clean" or .{git,hg}ignore. > Forgive me for pushing but, while you're here, do you mind taking a look and sharing your thoughts about the hunks of the patch touching XSM and FLASK? As I said, I've very few experience with that part of Xen, and it would be wonderful to know whether what I did looks sane, or I messed something up! :-P Thanks and Regards, Dario -- <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://retis.sssup.it/people/faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)