All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Franky Lin" <frankyl@broadcom.com>
To: linville@tuxdriver.com
Cc: linux-wireless@vger.kernel.org, "Hante Meuleman" <meuleman@broadcom.com>
Subject: [PATCH 04/14] brcmfmac: remove redundant function brcmf_c_mkiovar_bsscfg
Date: Mon, 22 Oct 2012 10:36:17 -0700	[thread overview]
Message-ID: <1350927387-25608-5-git-send-email-frankyl@broadcom.com> (raw)
In-Reply-To: <1350927387-25608-1-git-send-email-frankyl@broadcom.com>

From: Hante Meuleman <meuleman@broadcom.com>

function brcmf_c_mkiovar_bsscfg became redundant with refactoring
of firmware interface layer.

Reviewed-by: Arend Van Spriel <arend@broadcom.com>
Signed-off-by: Hante Meuleman <meuleman@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
---
 drivers/net/wireless/brcm80211/brcmfmac/dhd.h      |    2 -
 .../net/wireless/brcm80211/brcmfmac/dhd_common.c   |   46 --------------------
 2 files changed, 0 insertions(+), 48 deletions(-)

diff --git a/drivers/net/wireless/brcm80211/brcmfmac/dhd.h b/drivers/net/wireless/brcm80211/brcmfmac/dhd.h
index 1589c1b..faa81ef 100644
--- a/drivers/net/wireless/brcm80211/brcmfmac/dhd.h
+++ b/drivers/net/wireless/brcm80211/brcmfmac/dhd.h
@@ -709,8 +709,6 @@ extern const struct bcmevent_name bcmevent_names[];
 
 extern uint brcmf_c_mkiovar(char *name, char *data, uint datalen,
 			  char *buf, uint len);
-extern uint brcmf_c_mkiovar_bsscfg(char *name, char *data, uint datalen,
-				   char *buf, uint buflen, s32 bssidx);
 
 extern int brcmf_netdev_wait_pend8021x(struct net_device *ndev);
 
diff --git a/drivers/net/wireless/brcm80211/brcmfmac/dhd_common.c b/drivers/net/wireless/brcm80211/brcmfmac/dhd_common.c
index a081e68..aa4f719 100644
--- a/drivers/net/wireless/brcm80211/brcmfmac/dhd_common.c
+++ b/drivers/net/wireless/brcm80211/brcmfmac/dhd_common.c
@@ -88,52 +88,6 @@ brcmf_c_mkiovar(char *name, char *data, uint datalen, char *buf, uint buflen)
 	return len;
 }
 
-uint
-brcmf_c_mkiovar_bsscfg(char *name, char *data, uint datalen,
-		       char *buf, uint buflen, s32 bssidx)
-{
-	const s8 *prefix = "bsscfg:";
-	s8 *p;
-	u32 prefixlen;
-	u32 namelen;
-	u32 iolen;
-	__le32 bssidx_le;
-
-	if (bssidx == 0)
-		return brcmf_c_mkiovar(name, data, datalen, buf, buflen);
-
-	prefixlen = (u32) strlen(prefix); /* lengh of bsscfg prefix */
-	namelen = (u32) strlen(name) + 1; /* lengh of iovar  name + null */
-	iolen = prefixlen + namelen + sizeof(bssidx_le) + datalen;
-
-	if ((u32)buflen < iolen) {
-		brcmf_dbg(ERROR, "buffer is too short\n");
-		return 0;
-	}
-
-	p = buf;
-
-	/* copy prefix, no null */
-	memcpy(p, prefix, prefixlen);
-	p += prefixlen;
-
-	/* copy iovar name including null */
-	memcpy(p, name, namelen);
-	p += namelen;
-
-	/* bss config index as first data */
-	bssidx_le = cpu_to_le32(bssidx);
-	memcpy(p, &bssidx_le, sizeof(bssidx_le));
-	p += sizeof(bssidx_le);
-
-	/* parameter buffer follows */
-	if (datalen)
-		memcpy(p, data, datalen);
-
-	return iolen;
-
-}
-
 bool brcmf_c_prec_enq(struct device *dev, struct pktq *q,
 		      struct sk_buff *pkt, int prec)
 {
-- 
1.7.6



  parent reply	other threads:[~2012-10-22 17:36 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-22 17:36 [PATCH 00/14] brcmfmac: implementation of firmware interface layer Franky Lin
2012-10-22 17:36 ` [PATCH 01/14] brcmfmac: refactor " Franky Lin
2012-10-22 17:36 ` [PATCH 02/14] brcmfmac: remove unused iswl variable Franky Lin
2012-10-22 17:36 ` [PATCH 03/14] brcmfmac: change testmode command to use new firmware interface layer Franky Lin
2012-10-22 17:36 ` Franky Lin [this message]
2012-10-22 17:36 ` [PATCH 05/14] brcmfmac: clean usb download code Franky Lin
2012-10-22 17:36 ` [PATCH 06/14] brcmfmac: extend struct brcmf_if with bssidx field Franky Lin
2012-10-22 17:36 ` [PATCH 07/14] brcmfmac: rework driver initialization in brcmf_bus_start() Franky Lin
2012-10-22 17:36 ` [PATCH 08/14] brcmfmac: use bssidx from struct brcmf_if for bsscfg specific commands Franky Lin
2012-10-22 17:36 ` [PATCH 09/14] brcmfmac: add function converting ieee80211_channel to chanspec Franky Lin
2012-10-22 17:36 ` [PATCH 10/14] brcmfmac: use struct brcmf_if as interface object for fwil functions Franky Lin
2012-10-22 17:36 ` [PATCH 11/14] brcmfmac: streamline header parse code of sdio glom read Franky Lin
2012-10-22 17:36 ` [PATCH 12/14] brcmfmac: use fwil for default configuration setup Franky Lin
2012-10-22 17:36 ` [PATCH 13/14] brcmfmac: change parameter list for send_key_to_dongle() Franky Lin
2012-10-22 17:36 ` [PATCH 14/14] brcmfmac: remove brcmf_find_bssidx() function Franky Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1350927387-25608-5-git-send-email-frankyl@broadcom.com \
    --to=frankyl@broadcom.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=meuleman@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.