All of lore.kernel.org
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Stephane Eranian <eranian@google.com>
Cc: linux-kernel@vger.kernel.org, acme@redhat.com, jolsa@redhat.com,
	peterz@infradead.org, mingo@elte.hu, dsahern@gmail.com
Subject: Re: [PATCH] perf report: fix broken perf report -n on 32-bit systems
Date: Tue, 23 Oct 2012 22:48:40 +0900	[thread overview]
Message-ID: <1351000120.1520.0.camel@leonhard> (raw)
In-Reply-To: <20121022210025.GA10548@quad>

Hi Stephane,

2012-10-22 (월), 23:00 +0200, Stephane Eranian:
> On 32-bit systems, using perf report -n would yield garbage
> for the Samples column. This is because the hpp code was
> assuming the hist_entry.stat.nr_events was u64 when in
> reality it was u32.
> 
> This patch fixes the problem by defining nr_events
> to be u64. u32 is too small anyway.
> 
> Signed-off-by: Stephane Eranian <eranian@google.com>

Acked-by: Namhyung Kim <namhyung@kernel.org>

Thanks,
Namhyung



      reply	other threads:[~2012-10-23 13:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-22 21:00 [PATCH] perf report: fix broken perf report -n on 32-bit systems Stephane Eranian
2012-10-23 13:48 ` Namhyung Kim [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1351000120.1520.0.camel@leonhard \
    --to=namhyung@kernel.org \
    --cc=acme@redhat.com \
    --cc=dsahern@gmail.com \
    --cc=eranian@google.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.