All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tushar Behera <tushar.behera@linaro.org>
To: linux-kernel@vger.kernel.org
Cc: patches@linaro.org, Arnd Bergmann <arnd@arndb.de>
Subject: [PATCH 13/14] misc: tsl2550: Remove redundant check on unsigned variable
Date: Fri, 16 Nov 2012 12:20:45 +0530	[thread overview]
Message-ID: <1353048646-10935-14-git-send-email-tushar.behera@linaro.org> (raw)
In-Reply-To: <1353048646-10935-1-git-send-email-tushar.behera@linaro.org>

No need to check whether unsigned variable is less than 0.

CC: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
---
 drivers/misc/tsl2550.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/misc/tsl2550.c b/drivers/misc/tsl2550.c
index 0beb298..0438569 100644
--- a/drivers/misc/tsl2550.c
+++ b/drivers/misc/tsl2550.c
@@ -204,7 +204,7 @@ static ssize_t tsl2550_store_power_state(struct device *dev,
 	unsigned long val = simple_strtoul(buf, NULL, 10);
 	int ret;
 
-	if (val < 0 || val > 1)
+	if (val > 1)
 		return -EINVAL;
 
 	mutex_lock(&data->update_lock);
@@ -236,7 +236,7 @@ static ssize_t tsl2550_store_operating_mode(struct device *dev,
 	unsigned long val = simple_strtoul(buf, NULL, 10);
 	int ret;
 
-	if (val < 0 || val > 1)
+	if (val > 1)
 		return -EINVAL;
 
 	if (data->power_state == 0)
-- 
1.7.4.1


  parent reply	other threads:[~2012-11-16  6:57 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-16  6:50 [PATCH 00/14] Modify signed comparisons of unsigned variables Tushar Behera
2012-11-16  6:50 ` [PATCH 01/14] [media] ivtv: Remove redundant check on unsigned variable Tushar Behera
2012-11-16  6:50 ` [PATCH 02/14] [media] meye: " Tushar Behera
2012-11-16  6:50 ` [PATCH 03/14] [media] saa7134: " Tushar Behera
2012-11-16  6:50 ` [PATCH 04/14] [media] tlg2300: " Tushar Behera
2012-11-16  6:50 ` [PATCH 05/14] [media] atmel-isi: Update error check for unsigned variables Tushar Behera
2012-11-17 23:16   ` Guennadi Liakhovetski
2012-11-19  3:55     ` Tushar Behera
2012-11-16  6:50 ` [PATCH 06/14] pinctrl: samsung: " Tushar Behera
2012-11-17 20:31   ` Linus Walleij
2012-11-19  1:29     ` Kukjin Kim
2012-11-16  6:50 ` [PATCH 07/14] pinctrl: SPEAr: " Tushar Behera
2012-11-16  7:05   ` viresh kumar
2012-11-23  7:34   ` Linus Walleij
2012-11-16  6:50 ` [PATCH 08/14] xen: netback: Remove redundant check on unsigned variable Tushar Behera
2012-11-16  9:16   ` Ian Campbell
2012-12-28  5:15     ` Tushar Behera
2012-12-28 10:41       ` [Xen-devel] " Wei Liu
2012-12-28 10:41         ` Wei Liu
2013-01-02 21:40         ` Konrad Rzeszutek Wilk
2012-11-16  6:50 ` [PATCH 09/14] xen: events: " Tushar Behera
2012-11-16 16:09   ` Konrad Rzeszutek Wilk
2012-11-16 16:09     ` Konrad Rzeszutek Wilk
2012-11-16 16:53     ` Jeremy Fitzhardinge
2012-11-16 16:53     ` Jeremy Fitzhardinge
2012-11-19  3:52       ` Tushar Behera
2012-11-19  3:52         ` Tushar Behera
2012-11-19 10:31         ` [Xen-devel] " Ian Campbell
2012-11-19 10:31           ` Ian Campbell
2012-11-19 11:00           ` [Xen-devel] " Tushar Behera
2012-11-19 11:00             ` Tushar Behera
2012-11-19 10:31         ` Ian Campbell
2012-11-16  6:50 ` Tushar Behera
2012-11-16  6:50 ` [PATCH 10/14] atm: Removed " Tushar Behera
2012-12-28  5:16   ` Tushar Behera
2012-12-31 15:18     ` chas williams - CONTRACTOR
2012-11-16  6:50 ` [PATCH 11/14] HID: hiddev: Remove " Tushar Behera
2012-11-16  9:27   ` Jiri Kosina
2012-11-16  6:50 ` [PATCH 12/14] gru: " Tushar Behera
2012-11-16  6:50 ` Tushar Behera [this message]
2012-11-16  8:09   ` [PATCH 13/14] misc: tsl2550: " Arnd Bergmann
2012-11-16  6:50 ` [PATCH 14/14] wlcore: " Tushar Behera
2012-11-16 18:24   ` Luciano Coelho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1353048646-10935-14-git-send-email-tushar.behera@linaro.org \
    --to=tushar.behera@linaro.org \
    --cc=arnd@arndb.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patches@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.