From: Joe Perches <joe@perches.com>
To: Andy Whitcroft <apw@canonical.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Constantine Shulyupin <const@makelinux.com>,
linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org
Subject: [PATCH] checkpatch: Allow control over line length warning, default remains 80
Date: Tue, 20 Nov 2012 12:57:30 -0800 [thread overview]
Message-ID: <1353445050.17819.16.camel@joe-AO722> (raw)
In-Reply-To: <20121120152227.GI7955@dm>
Some projects might want a longer line length so allow
a command line --max-line-length=n control over the
long line warnings. The default line length is 80.
Signed-off-by: Joe Perches <joe@perches.com>
---
scripts/checkpatch.pl | 9 ++++++---
1 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index d2d5ba1..38e8890 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -33,6 +33,7 @@ my %ignore_type = ();
my @ignore = ();
my $help = 0;
my $configuration_file = ".checkpatch.conf";
+my $max_line_length = 80;
sub help {
my ($exitcode) = @_;
@@ -51,6 +52,7 @@ Options:
-f, --file treat FILE as regular source file
--subjective, --strict enable more subjective tests
--ignore TYPE(,TYPE2...) ignore various comma separated message types
+ --max-line-length=n set the maximum line length, if exceeded, warn
--show-types show the message "types" in the output
--root=PATH PATH to the kernel tree root
--no-summary suppress the per-file summary
@@ -107,6 +109,7 @@ GetOptions(
'strict!' => \$check,
'ignore=s' => \@ignore,
'show-types!' => \$show_types,
+ 'max-line-length=i' => \$max_line_length,
'root=s' => \$root,
'summary!' => \$summary,
'mailback!' => \$mailback,
@@ -1760,15 +1763,15 @@ sub process {
# check we are in a valid source file if not then ignore this hunk
next if ($realfile !~ /\.(h|c|s|S|pl|sh)$/);
-#80 column limit
+#line length limit
if ($line =~ /^\+/ && $prevrawline !~ /\/\*\*/ &&
$rawline !~ /^.\s*\*\s*\@$Ident\s/ &&
!($line =~ /^\+\s*$logFunctions\s*\(\s*(?:(KERN_\S+\s*|[^"]*))?"[X\t]*"\s*(?:|,|\)\s*;)\s*$/ ||
$line =~ /^\+\s*"[^"]*"\s*(?:\s*|,|\)\s*;)\s*$/) &&
- $length > 80)
+ $length > $max_line_length)
{
WARN("LONG_LINE",
- "line over 80 characters\n" . $herecurr);
+ "line over $max_line_length characters\n" . $herecurr);
}
# Check for user-visible strings broken across lines, which breaks the ability
next prev parent reply other threads:[~2012-11-20 20:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-17 22:20 [PATCH v4] checkpatch: debugfs_remove() can take NULL Constantine Shulyupin
2012-11-20 14:29 ` Andy Whitcroft
2012-11-20 14:43 ` Joe Perches
2012-11-20 14:47 ` Andy Whitcroft
2012-11-20 14:50 ` Constantine Shulyupin
2012-11-20 14:58 ` Joe Perches
2012-11-20 15:10 ` Constantine Shulyupin
2012-11-20 15:22 ` Andy Whitcroft
2012-11-20 20:57 ` Joe Perches [this message]
2012-11-20 15:37 ` [PATCH] checkpatch: consolidate if (foo) bar(foo) checks and add debugfs_remove Andy Whitcroft
2012-11-20 15:51 ` Joe Perches
2012-11-20 16:39 ` Andy Whitcroft
2012-11-20 18:37 ` Joe Perches
2012-11-20 19:17 ` [PATCH V2] " Andy Whitcroft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1353445050.17819.16.camel@joe-AO722 \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=const@makelinux.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.