From: Johannes Berg <johannes@sipsolutions.net>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Ben Greear" <greearb@candelatech.com>,
"Bjørn Mork" <bjorn@mork.no>,
linux-wireless@vger.kernel.org,
"Ben Hutchings" <bhutchings@solarflare.com>,
"Michał Mirosław" <mirqus@gmail.com>
Subject: Re: [PATCH v3] net, wireless: overwrite default_ethtool_ops
Date: Fri, 11 Jan 2013 11:51:47 +0100 [thread overview]
Message-ID: <1357901507.9767.0.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <20130111091909.GA2347@redhat.com> (sfid-20130111_101938_088871_22B76855)
On Fri, 2013-01-11 at 10:19 +0100, Stanislaw Gruszka wrote:
> Since:
>
> commit 2c60db037034d27f8c636403355d52872da92f81
> Author: Eric Dumazet <edumazet@google.com>
> Date: Sun Sep 16 09:17:26 2012 +0000
>
> net: provide a default dev->ethtool_ops
>
> wireless core does not correctly assign ethtool_ops.
>
> After alloc_netdev*() call, some cfg80211 drivers provide they own
> ethtool_ops, but some do not. For them, wireless core provide generic
> cfg80211_ethtool_ops, which is assigned in NETDEV_REGISTER notify call:
>
> if (!dev->ethtool_ops)
> dev->ethtool_ops = &cfg80211_ethtool_ops;
>
> But after Eric's commit, dev->ethtool_ops is no longer NULL (on cfg80211
> drivers without custom ethtool_ops), but points to &default_ethtool_ops.
>
> In order to fix the problem, provide function which will overwrite
> default_ethtool_ops and use it by wireless core.
>
> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Acked-by: Johannes Berg <johannes@sipsolutions.net>
This will work nicely, clearly I didn't understand davem's suggestion :)
johannes
next prev parent reply other threads:[~2013-01-11 10:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-11 9:19 [PATCH v3] net, wireless: overwrite default_ethtool_ops Stanislaw Gruszka
2013-01-11 10:51 ` Johannes Berg [this message]
2013-01-11 20:00 ` Ben Hutchings
2013-01-11 23:59 ` David Miller
2013-01-11 23:59 ` David Miller
2013-01-21 20:52 ` Luis R. Rodriguez
2013-01-21 21:04 ` David Miller
2013-01-21 21:47 ` Luis R. Rodriguez
2013-01-21 21:47 ` Luis R. Rodriguez
2013-01-22 10:56 ` Stanislaw Gruszka
2013-01-22 10:56 ` Stanislaw Gruszka
2013-01-22 19:06 ` David Miller
2013-01-22 19:06 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1357901507.9767.0.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=bhutchings@solarflare.com \
--cc=bjorn@mork.no \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mirqus@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.