All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
To: linux-mmc@vger.kernel.org
Cc: linux-sh@vger.kernel.org, Magnus Damm <magnus.damm@gmail.com>
Subject: [PATCH 02/11] mmc: deprecate redundant cd-inverted and wp-inverted DT properties
Date: Wed, 16 Jan 2013 16:54:37 +0000	[thread overview]
Message-ID: <1358355286-26029-3-git-send-email-g.liakhovetski@gmx.de> (raw)
In-Reply-To: <1358355286-26029-1-git-send-email-g.liakhovetski@gmx.de>

GPIO DT bindings have a standard way to specify GPIO polarity - the
OF_GPIO_ACTIVE_LOW flag. Use that instead of custom cd-inverted and
wp-inverted properties.

Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
---
 Documentation/devicetree/bindings/mmc/mmc.txt |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/Documentation/devicetree/bindings/mmc/mmc.txt b/Documentation/devicetree/bindings/mmc/mmc.txt
index 34f28ed..e180892 100644
--- a/Documentation/devicetree/bindings/mmc/mmc.txt
+++ b/Documentation/devicetree/bindings/mmc/mmc.txt
@@ -19,11 +19,19 @@ Only one of the properties in this section should be supplied:
 Optional properties:
 - wp-gpios: Specify GPIOs for write protection, see gpio binding
 - cd-inverted: when present, polarity on the cd gpio line is inverted
+  (deprecated)
 - wp-inverted: when present, polarity on the wp gpio line is inverted
+  (deprecated)
 - max-frequency: maximum operating clock frequency
 - no-1-8-v: when present, denotes that 1.8v card voltage is not supported on
   this system, even if the controller claims it is.
 
+cd-inverted and wp-inverted properties are deprecated ans shouldn't be used,
+instead pleaseuse the OF_GPIO_ACTIVE_LOW flag in respective GPIO bindings. Note,
+that the default (as defined by the SDHCI standard) CD and WP polarity is
+active-low, so, OF_GPIO_ACTIVE_LOW should normally be set, and only be left
+clear, if the polarity is inverted.
+
 Optional SDIO properties:
 - keep-power-in-suspend: Preserves card power during a suspend/resume cycle
 - enable-sdio-wakeup: Enables wake up of host system on SDIO IRQ assertion
-- 
1.7.2.5


WARNING: multiple messages have this Message-ID (diff)
From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
To: linux-mmc@vger.kernel.org
Cc: linux-sh@vger.kernel.org, Magnus Damm <magnus.damm@gmail.com>
Subject: [PATCH 02/11] mmc: deprecate redundant cd-inverted and wp-inverted DT properties
Date: Wed, 16 Jan 2013 17:54:37 +0100	[thread overview]
Message-ID: <1358355286-26029-3-git-send-email-g.liakhovetski@gmx.de> (raw)
In-Reply-To: <1358355286-26029-1-git-send-email-g.liakhovetski@gmx.de>

GPIO DT bindings have a standard way to specify GPIO polarity - the
OF_GPIO_ACTIVE_LOW flag. Use that instead of custom cd-inverted and
wp-inverted properties.

Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
---
 Documentation/devicetree/bindings/mmc/mmc.txt |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/Documentation/devicetree/bindings/mmc/mmc.txt b/Documentation/devicetree/bindings/mmc/mmc.txt
index 34f28ed..e180892 100644
--- a/Documentation/devicetree/bindings/mmc/mmc.txt
+++ b/Documentation/devicetree/bindings/mmc/mmc.txt
@@ -19,11 +19,19 @@ Only one of the properties in this section should be supplied:
 Optional properties:
 - wp-gpios: Specify GPIOs for write protection, see gpio binding
 - cd-inverted: when present, polarity on the cd gpio line is inverted
+  (deprecated)
 - wp-inverted: when present, polarity on the wp gpio line is inverted
+  (deprecated)
 - max-frequency: maximum operating clock frequency
 - no-1-8-v: when present, denotes that 1.8v card voltage is not supported on
   this system, even if the controller claims it is.
 
+cd-inverted and wp-inverted properties are deprecated ans shouldn't be used,
+instead pleaseuse the OF_GPIO_ACTIVE_LOW flag in respective GPIO bindings. Note,
+that the default (as defined by the SDHCI standard) CD and WP polarity is
+active-low, so, OF_GPIO_ACTIVE_LOW should normally be set, and only be left
+clear, if the polarity is inverted.
+
 Optional SDIO properties:
 - keep-power-in-suspend: Preserves card power during a suspend/resume cycle
 - enable-sdio-wakeup: Enables wake up of host system on SDIO IRQ assertion
-- 
1.7.2.5


  parent reply	other threads:[~2013-01-16 16:54 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-16 16:54 [PATCH 00/11] mmc: core and driver DT and related development Guennadi Liakhovetski
2013-01-16 16:54 ` Guennadi Liakhovetski
2013-01-16 16:54 ` [PATCH 01/11] mmc: sdhi, tmio: only check flags in tmio-mmc driver proper Guennadi Liakhovetski
2013-01-16 16:54   ` Guennadi Liakhovetski
2013-01-16 16:54 ` Guennadi Liakhovetski [this message]
2013-01-16 16:54   ` [PATCH 02/11] mmc: deprecate redundant cd-inverted and wp-inverted DT properties Guennadi Liakhovetski
2013-01-16 16:54 ` [PATCH 03/11] mmc: provide a standard MMC device-tree binding parser centrally Guennadi Liakhovetski
2013-01-16 16:54   ` Guennadi Liakhovetski
2013-01-16 16:54 ` [PATCH 04/11] mmc: (cosmetic) remove "extern" from function declarations Guennadi Liakhovetski
2013-01-16 16:54   ` Guennadi Liakhovetski
2013-01-16 16:54 ` [PATCH 05/11] mmc: sh-mmcif: use mmc_of_parse() to parse standard MMC DT bindings Guennadi Liakhovetski
2013-01-16 16:54   ` Guennadi Liakhovetski
2013-01-16 16:54 ` [PATCH/RFC 06/11] mmc: tmio-mmc: define device-tree bindings Guennadi Liakhovetski
2013-01-16 16:54   ` Guennadi Liakhovetski
2013-01-16 16:54 ` [PATCH 07/11] mmc: tmio-mmc: parse " Guennadi Liakhovetski
2013-01-16 16:54   ` Guennadi Liakhovetski
2013-01-16 16:54 ` [PATCH 08/11] mmc: sh_mobile_sdhi: remove unused .pdata field Guennadi Liakhovetski
2013-01-16 16:54   ` Guennadi Liakhovetski
2013-01-16 16:54 ` [PATCH 09/11] mmc: sh_mobile_sdhi: use managed resource allocations Guennadi Liakhovetski
2013-01-16 16:54   ` Guennadi Liakhovetski
2013-01-16 16:54 ` [PATCH 10/11] mmc: tmio: remove unused and deprecated symbols Guennadi Liakhovetski
2013-01-16 16:54   ` Guennadi Liakhovetski
2013-01-16 16:54 ` [PATCH 11/11] mmc: tmio: add support for the VccQ regulator Guennadi Liakhovetski
2013-01-16 16:54   ` Guennadi Liakhovetski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1358355286-26029-3-git-send-email-g.liakhovetski@gmx.de \
    --to=g.liakhovetski@gmx.de \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.