From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755640Ab3ARVHd (ORCPT ); Fri, 18 Jan 2013 16:07:33 -0500 Received: from server.prisktech.co.nz ([115.188.14.127]:53503 "EHLO server.prisktech.co.nz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752211Ab3ARVHc (ORCPT ); Fri, 18 Jan 2013 16:07:32 -0500 Message-ID: <1358543280.8280.2.camel@gitbox> Subject: Re: [PATCH 5/7] clk: vt8500: Use common of_clk_init() function From: Tony Prisk To: Mike Turquette Cc: Prashant Gaikwad , swarren@nvidia.com, grant.likely@secretlab.ca, linus.walleij@linaro.org, rob.herring@calxeda.com, maxime.ripard@free-electrons.com, josh.cartwright@ni.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Date: Sat, 19 Jan 2013 10:08:00 +1300 In-Reply-To: <20130118175621.3982.82838@quantum> References: <1357282858-2112-1-git-send-email-pgaikwad@nvidia.com> <1357282858-2112-5-git-send-email-pgaikwad@nvidia.com> <20130118175621.3982.82838@quantum> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2013-01-18 at 09:56 -0800, Mike Turquette wrote: > Quoting Prashant Gaikwad (2013-01-03 23:00:56) > > Use common of_clk_init() function for clock initialization. > > > > Signed-off-by: Prashant Gaikwad > > Tony, > > Can I get a Tested-by from you before I take this in? > Tested-by: Tony Prisk FYI: This will need another patch to complete as we added another set of clocks to this clk-vt8500.c for 3.9. > Thanks, > Mike > > > --- > > drivers/clk/clk-vt8500.c | 15 ++++----------- > > 1 files changed, 4 insertions(+), 11 deletions(-) > > > > diff --git a/drivers/clk/clk-vt8500.c b/drivers/clk/clk-vt8500.c > > index fe25570..3ce1c3e 100644 > > --- a/drivers/clk/clk-vt8500.c > > +++ b/drivers/clk/clk-vt8500.c > > @@ -272,7 +272,7 @@ static __init void vtwm_device_clk_init(struct device_node *node) > > rc = of_clk_add_provider(node, of_clk_src_simple_get, clk); > > clk_register_clkdev(clk, clk_name, NULL); > > } > > - > > +CLK_OF_DECLARE(vt8500_device, "via,vt8500-device-clock", vtwm_device_clk_init); > > > > /* PLL clock related functions */ > > > > @@ -502,20 +502,13 @@ static void __init vt8500_pll_init(struct device_node *node) > > { > > vtwm_pll_clk_init(node, PLL_TYPE_VT8500); > > } > > +CLK_OF_DECLARE(vt8500_pll, "via,vt8500-pll-clock", vt8500_pll_init); > > > > static void __init wm8650_pll_init(struct device_node *node) > > { > > vtwm_pll_clk_init(node, PLL_TYPE_WM8650); > > } > > - > > -static const __initconst struct of_device_id clk_match[] = { > > - { .compatible = "fixed-clock", .data = of_fixed_clk_setup, }, > > - { .compatible = "via,vt8500-pll-clock", .data = vt8500_pll_init, }, > > - { .compatible = "wm,wm8650-pll-clock", .data = wm8650_pll_init, }, > > - { .compatible = "via,vt8500-device-clock", > > - .data = vtwm_device_clk_init, }, > > - { /* sentinel */ } > > -}; > > +CLK_OF_DECLARE(wm8650_pll, "wm,wm8650-pll-clock", wm8650_pll_init); > > > > void __init vtwm_clk_init(void __iomem *base) > > { > > @@ -524,5 +517,5 @@ void __init vtwm_clk_init(void __iomem *base) > > > > pmc_base = base; > > > > - of_clk_init(clk_match); > > + of_clk_init(NULL); > > } > > -- > > 1.7.4.1 > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: linux@prisktech.co.nz (Tony Prisk) Date: Sat, 19 Jan 2013 10:08:00 +1300 Subject: [PATCH 5/7] clk: vt8500: Use common of_clk_init() function In-Reply-To: <20130118175621.3982.82838@quantum> References: <1357282858-2112-1-git-send-email-pgaikwad@nvidia.com> <1357282858-2112-5-git-send-email-pgaikwad@nvidia.com> <20130118175621.3982.82838@quantum> Message-ID: <1358543280.8280.2.camel@gitbox> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, 2013-01-18 at 09:56 -0800, Mike Turquette wrote: > Quoting Prashant Gaikwad (2013-01-03 23:00:56) > > Use common of_clk_init() function for clock initialization. > > > > Signed-off-by: Prashant Gaikwad > > Tony, > > Can I get a Tested-by from you before I take this in? > Tested-by: Tony Prisk FYI: This will need another patch to complete as we added another set of clocks to this clk-vt8500.c for 3.9. > Thanks, > Mike > > > --- > > drivers/clk/clk-vt8500.c | 15 ++++----------- > > 1 files changed, 4 insertions(+), 11 deletions(-) > > > > diff --git a/drivers/clk/clk-vt8500.c b/drivers/clk/clk-vt8500.c > > index fe25570..3ce1c3e 100644 > > --- a/drivers/clk/clk-vt8500.c > > +++ b/drivers/clk/clk-vt8500.c > > @@ -272,7 +272,7 @@ static __init void vtwm_device_clk_init(struct device_node *node) > > rc = of_clk_add_provider(node, of_clk_src_simple_get, clk); > > clk_register_clkdev(clk, clk_name, NULL); > > } > > - > > +CLK_OF_DECLARE(vt8500_device, "via,vt8500-device-clock", vtwm_device_clk_init); > > > > /* PLL clock related functions */ > > > > @@ -502,20 +502,13 @@ static void __init vt8500_pll_init(struct device_node *node) > > { > > vtwm_pll_clk_init(node, PLL_TYPE_VT8500); > > } > > +CLK_OF_DECLARE(vt8500_pll, "via,vt8500-pll-clock", vt8500_pll_init); > > > > static void __init wm8650_pll_init(struct device_node *node) > > { > > vtwm_pll_clk_init(node, PLL_TYPE_WM8650); > > } > > - > > -static const __initconst struct of_device_id clk_match[] = { > > - { .compatible = "fixed-clock", .data = of_fixed_clk_setup, }, > > - { .compatible = "via,vt8500-pll-clock", .data = vt8500_pll_init, }, > > - { .compatible = "wm,wm8650-pll-clock", .data = wm8650_pll_init, }, > > - { .compatible = "via,vt8500-device-clock", > > - .data = vtwm_device_clk_init, }, > > - { /* sentinel */ } > > -}; > > +CLK_OF_DECLARE(wm8650_pll, "wm,wm8650-pll-clock", wm8650_pll_init); > > > > void __init vtwm_clk_init(void __iomem *base) > > { > > @@ -524,5 +517,5 @@ void __init vtwm_clk_init(void __iomem *base) > > > > pmc_base = base; > > > > - of_clk_init(clk_match); > > + of_clk_init(NULL); > > } > > -- > > 1.7.4.1 > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel at lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel