From: Ian Jackson <ian.jackson@eu.citrix.com>
To: xen-devel@lists.xen.org
Cc: Jim Fehlig <jfehlig@suse.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
Ian Campbell <Ian.Campbell@citrix.com>,
Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>
Subject: [PATCH 2/4] libxl: Fix passing of application data to timeout_deregister hook
Date: Wed, 23 Jan 2013 16:56:48 +0000 [thread overview]
Message-ID: <1358960210-22667-3-git-send-email-ian.jackson@eu.citrix.com> (raw)
In-Reply-To: <1358960210-22667-1-git-send-email-ian.jackson@eu.citrix.com>
From: Jim Fehlig <jfehlig@suse.com>
When deregistering a timeout, the address of application data was
being passed to the timeout_deregister hook instead of the data
itself.
Signed-off-by: Jim Fehlig <jfehlig@suse.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
Committed-by: Ian Campbell <ian.campbell@citrix.com>
xen-unstable changeset: 26155:babb84d9a82e
Backport-requested-by: Ian Jackson <ian.jackson@eu.citrix.com>
Backported-by: Ian Jackson <ian.jackson@eu.citrix.com>
Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
---
tools/libxl/libxl_event.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/tools/libxl/libxl_event.c b/tools/libxl/libxl_event.c
index aea58bb..06a29f2 100644
--- a/tools/libxl/libxl_event.c
+++ b/tools/libxl/libxl_event.c
@@ -184,7 +184,7 @@ static int time_register_finite(libxl__gc *gc, libxl__ev_time *ev,
static void time_deregister(libxl__gc *gc, libxl__ev_time *ev)
{
if (!ev->infinite) {
- OSEVENT_HOOK_VOID(timeout_deregister, &ev->for_app_reg);
+ OSEVENT_HOOK_VOID(timeout_deregister, ev->for_app_reg);
LIBXL_TAILQ_REMOVE(&CTX->etimes, ev, entry);
}
}
--
1.7.2.5
next prev parent reply other threads:[~2013-01-23 16:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-23 16:56 [PATCH 0/4] XEN 4.2 libxl: fix event races exposed by libvirt Ian Jackson
2013-01-23 16:56 ` [PATCH 1/4] libxl: rename "abs" variables to "absolute" Ian Jackson
2013-01-23 16:56 ` Ian Jackson [this message]
2013-01-23 22:00 ` [PATCH 2/4] libxl: Fix passing of application data to timeout_deregister hook Jim Fehlig
2013-01-23 16:56 ` [PATCH 3/4] libxl: fix stale fd event callback race Ian Jackson
2013-01-23 16:56 ` [PATCH 4/4] libxl: fix stale timeout " Ian Jackson
2013-01-23 17:54 ` [PATCH 0/4] XEN 4.2 libxl: fix event races exposed by libvirt Stefano Stabellini
2013-02-22 18:48 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1358960210-22667-3-git-send-email-ian.jackson@eu.citrix.com \
--to=ian.jackson@eu.citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=Stefano.Stabellini@eu.citrix.com \
--cc=jfehlig@suse.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.