From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Date: Wed, 23 Jan 2013 15:52:04 -0600 Subject: [U-Boot] [Patch v3] Consolidate bool type In-Reply-To: <51005A1C.1010308@freescale.com> (from yorksun@freescale.com on Wed Jan 23 15:46:04 2013) References: <1358977307-17350-1-git-send-email-yorksun@freescale.com> <51005A1C.1010308@freescale.com> Message-ID: <1358977924.9710.8@snotra> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 01/23/2013 03:46:04 PM, York Sun wrote: > On 01/23/2013 01:41 PM, York Sun wrote: > > 'bool' is defined in random places. This patch consolidates them > into a > > single header file include/linux/types.h, using stdbool.h. > > > > All other #define, typedef and enum are removed. They are all > consistent with > > true = 1, false = 0. > > > > Signed-off-by: York Sun > > --- > > Change since v1: > > Move 'false' and 'true' to the common header file. > > > > Change since v2: > > Use stdbool.h > > Consolidate all TRUE, FALSE, True, False, true, false > > > > Need help to test on all ARCHs with differnt toolchains as well as > USE_PRIVATE_LIBGCC. > > > > > I should put RFC in the subject as I am not able to compile all ARCH > myself. So how do you see this patch becoming non-RFC? I think most people don't have every single toolchain. You should at least get a toolchain for a couple major architectures such as ARM. Usually RFC is for when you know the patch has issues, and don't want it applied yet even if nobody else finds fault with it. -Scott