From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH]: PVH: specify xen features strings cleany
 for PVH
Date: Fri, 25 Jan 2013 10:11:43 +0000
Message-ID: <1359108703.10051.5.camel@zakaz.uk.xensource.com>
References: <20130118173503.71de0603@mantra.us.oracle.com>
	<50FD3D6202000078000B7CE4@nat28.tlf.novell.com>
	<20130122151241.7ed034f4@mantra.us.oracle.com>
	<50FFABE702000078000B88E1@nat28.tlf.novell.com>
	<20130123144347.78ba0a3f@mantra.us.oracle.com>
	<51010A1802000078000B9027@nat28.tlf.novell.com>
	<20130124151336.311c3456@mantra.us.oracle.com>
	<51024A2602000078000B9786@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <51024A2602000078000B9786@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xen.org>, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
List-Id: xen-devel@lists.xenproject.org

On Fri, 2013-01-25 at 08:02 +0000, Jan Beulich wrote:
> >>> On 25.01.13 at 00:13, Mukesh Rathor <mukesh.rathor@oracle.com> wrote:
> > This is on top of what konrad already has in his linux tree so he
> > can just apply it. Here's the final version of the file, just in case:
> 
> Looks okay to me, and I don't mind whether this
> 
> >         ELFNOTE(Xen, XEN_ELFNOTE_FEATURES,       .ascii 
> > "!writable_page_tables|pae_pgdir_above_4gb"; .asciz PVH_FEATURES_STR);
> 
> is done using the .ascii/.asciz or the simpler string concatenation
> way, as long as the latter works.

String concat in gas doesn't work like in C, you get a \0 at the join...

>  All I do mind are redundancy
> and embedded \0 characters.
> 
> Jan
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel