All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Marco Porsch <marco@cozybit.com>
Cc: mcgrof@qca.qualcomm.com, jouni@qca.qualcomm.com,
	vthiagar@qca.qualcomm.com, senthilb@qca.qualcomm.com,
	linux-wireless@vger.kernel.org, devel@lists.open80211s.org,
	ath9k-devel@lists.ath9k.org
Subject: Re: [RFC 1/3] mac80211: move mesh sync beacon handler into neighbour_update
Date: Thu, 31 Jan 2013 14:43:00 +0100	[thread overview]
Message-ID: <1359639780.8415.23.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1358936360-7795-2-git-send-email-marco@cozybit.com> (sfid-20130123_111931_474759_EEC1974B)

On Wed, 2013-01-23 at 11:19 +0100, Marco Porsch wrote:
> Move the beacon handler into mesh_neighbour_update where the STA
> pointer is already available. This avoids additional overhead
> and simplifies the handler.
> The repositioning will also benefit mesh PS which uses the
> T_offset value right after it has been updated.
> 
> Rename the handler to better reflect its purpose.
> 
> Signed-off-by: Marco Porsch <marco@cozybit.com>
> ---
>  net/mac80211/ieee80211_i.h |   10 +++++-----
>  net/mac80211/mesh.c        |    8 ++------
>  net/mac80211/mesh.h        |    5 +++--
>  net/mac80211/mesh_plink.c  |   16 ++++++++++++---
>  net/mac80211/mesh_sync.c   |   47 +++++++++++++++-----------------------------
>  5 files changed, 39 insertions(+), 47 deletions(-)
> 
> diff --git a/net/mac80211/ieee80211_i.h b/net/mac80211/ieee80211_i.h
> index d77d3f7..e08b4c0 100644
> --- a/net/mac80211/ieee80211_i.h
> +++ b/net/mac80211/ieee80211_i.h
> @@ -560,11 +560,11 @@ struct ieee80211_if_ibss {
>   */
>  struct ieee802_11_elems;
>  struct ieee80211_mesh_sync_ops {
> -	void (*rx_bcn_presp)(struct ieee80211_sub_if_data *sdata,
> -			     u16 stype,
> -			     struct ieee80211_mgmt *mgmt,
> -			     struct ieee802_11_elems *elems,
> -			     struct ieee80211_rx_status *rx_status);
> +	void (*rx_bcn)(struct sta_info *sta,
> +		       struct ieee80211_mgmt *mgmt,
> +		       struct ieee802_11_elems *elems,
> +		       struct ieee80211_rx_status *rx_status,
> +		       u64 tsf);

Is anyone actually planning to add more sync ops? I'm tempted to just
remove the entire abstraction here, since there's only a single concrete
implementation.

johannes


WARNING: multiple messages have this Message-ID (diff)
From: Johannes Berg <johannes@sipsolutions.net>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [RFC 1/3] mac80211: move mesh sync beacon handler into neighbour_update
Date: Thu, 31 Jan 2013 14:43:00 +0100	[thread overview]
Message-ID: <1359639780.8415.23.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1358936360-7795-2-git-send-email-marco@cozybit.com> (sfid-20130123_111931_474759_EEC1974B)

On Wed, 2013-01-23 at 11:19 +0100, Marco Porsch wrote:
> Move the beacon handler into mesh_neighbour_update where the STA
> pointer is already available. This avoids additional overhead
> and simplifies the handler.
> The repositioning will also benefit mesh PS which uses the
> T_offset value right after it has been updated.
> 
> Rename the handler to better reflect its purpose.
> 
> Signed-off-by: Marco Porsch <marco@cozybit.com>
> ---
>  net/mac80211/ieee80211_i.h |   10 +++++-----
>  net/mac80211/mesh.c        |    8 ++------
>  net/mac80211/mesh.h        |    5 +++--
>  net/mac80211/mesh_plink.c  |   16 ++++++++++++---
>  net/mac80211/mesh_sync.c   |   47 +++++++++++++++-----------------------------
>  5 files changed, 39 insertions(+), 47 deletions(-)
> 
> diff --git a/net/mac80211/ieee80211_i.h b/net/mac80211/ieee80211_i.h
> index d77d3f7..e08b4c0 100644
> --- a/net/mac80211/ieee80211_i.h
> +++ b/net/mac80211/ieee80211_i.h
> @@ -560,11 +560,11 @@ struct ieee80211_if_ibss {
>   */
>  struct ieee802_11_elems;
>  struct ieee80211_mesh_sync_ops {
> -	void (*rx_bcn_presp)(struct ieee80211_sub_if_data *sdata,
> -			     u16 stype,
> -			     struct ieee80211_mgmt *mgmt,
> -			     struct ieee802_11_elems *elems,
> -			     struct ieee80211_rx_status *rx_status);
> +	void (*rx_bcn)(struct sta_info *sta,
> +		       struct ieee80211_mgmt *mgmt,
> +		       struct ieee802_11_elems *elems,
> +		       struct ieee80211_rx_status *rx_status,
> +		       u64 tsf);

Is anyone actually planning to add more sync ops? I'm tempted to just
remove the entire abstraction here, since there's only a single concrete
implementation.

johannes

  reply	other threads:[~2013-01-31 13:42 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-23 10:19 [RFC 0/3] mesh power save - hardware doze Marco Porsch
2013-01-23 10:19 ` [ath9k-devel] " Marco Porsch
2013-01-23 10:19 ` [RFC 1/3] mac80211: move mesh sync beacon handler into neighbour_update Marco Porsch
2013-01-23 10:19   ` [ath9k-devel] " Marco Porsch
2013-01-31 13:43   ` Johannes Berg [this message]
2013-01-31 13:43     ` Johannes Berg
2013-01-31 15:28     ` Marco Porsch
2013-01-31 15:28       ` [ath9k-devel] " Marco Porsch
2013-02-02 17:53       ` Sam Leffler
2013-01-23 10:19 ` [RFC 2/3] mac80211: mesh power save doze scheduling Marco Porsch
2013-01-23 10:19   ` [ath9k-devel] " Marco Porsch
2013-01-23 19:16   ` Thomas Pedersen
2013-01-23 19:16     ` [ath9k-devel] " Thomas Pedersen
2013-01-31 13:51   ` Johannes Berg
2013-01-31 13:51     ` [ath9k-devel] " Johannes Berg
2013-01-31 15:23     ` Marco Porsch
2013-01-31 15:23       ` [ath9k-devel] " Marco Porsch
2013-01-31 15:34       ` Johannes Berg
2013-01-31 15:34         ` [ath9k-devel] " Johannes Berg
2013-01-23 10:19 ` [RFC 3/3] ath9k: mesh powersave support Marco Porsch
2013-01-23 10:19   ` [ath9k-devel] " Marco Porsch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1359639780.8415.23.camel@jlt4.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=ath9k-devel@lists.ath9k.org \
    --cc=devel@lists.open80211s.org \
    --cc=jouni@qca.qualcomm.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=marco@cozybit.com \
    --cc=mcgrof@qca.qualcomm.com \
    --cc=senthilb@qca.qualcomm.com \
    --cc=vthiagar@qca.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.