From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: Is: PVH + ARM new hypercalls. Was: Re: [PATCH]: PVH: specify xen features strings cleany for PVH Date: Mon, 4 Feb 2013 10:31:41 +0000 Message-ID: <1359973901.5281.35.camel@zakaz.uk.xensource.com> References: <50FD3D6202000078000B7CE4@nat28.tlf.novell.com> <20130122151241.7ed034f4@mantra.us.oracle.com> <50FFABE702000078000B88E1@nat28.tlf.novell.com> <20130123144347.78ba0a3f@mantra.us.oracle.com> <51010A1802000078000B9027@nat28.tlf.novell.com> <20130124151336.311c3456@mantra.us.oracle.com> <51024A2602000078000B9786@nat28.tlf.novell.com> <1359108703.10051.5.camel@zakaz.uk.xensource.com> <51026C3602000078000B9911@nat28.tlf.novell.com> <1359110621.10051.25.camel@zakaz.uk.xensource.com> <20130128162607.GA7223@konrad-lan.dumpdata.com> <20130128185737.55ec65f8@mantra.us.oracle.com> <5107B6FC02000078000BA589@nat28.tlf.novell.com> <20130131182329.2cb3a225@mantra.us.oracle.com> <510BEC590200007800094177@nat28.tlf.novell.com> <20130201112716.4d63716c@mantra.us.oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20130201112716.4d63716c@mantra.us.oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Mukesh Rathor Cc: "konrad@kernel.org" , "konrad.wilk@oracle.com" , Jan Beulich , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On Fri, 2013-02-01 at 19:27 +0000, Mukesh Rathor wrote: > On Fri, 01 Feb 2013 16:24:57 +0000 > "Jan Beulich" wrote: > > > >>> Mukesh Rathor 02/01/13 3:23 AM >>> > > >On Tue, 29 Jan 2013 10:48:12 +0000 "Jan Beulich" > > >wrote: > > >> >>> On 29.01.13 at 03:57, Mukesh Rathor > > >> >>> wrote: > > >> difficult, but I continue to see more advantage in avoiding the > > >> redundancy). > > > > > >That was my patch version 2, where I called it gdt and another > > >reviewer suggested to change to u. So I changed it to u. > > > > > >It's gone thru enough iterations that I'd like to leave as is. Thank > > >you in advance for your compromise in helping us mortals grep/cscope > > >to learn code. > > > > That's part of the reason why I said from the beginning that doing > > the Linux side first is wrong. > > It was reviewed by xen folks like Ian C, Stefano, etc... Well, that doesn't in any way mean that Jan's opinion isn't valid or relevant and where reviewers/authors cannot reach consensus over something then it is ultimately the maintainer's call. I deliberately avoided formally Acking any of the Linux side patches until the hypervisor side was posted and reviewed, precisely because it is necessary to review the hypervisor interfaces as part of the hypervisor changes before committing to them. I believe we explicitly agreed that the interface would be subject to change when the hypervisor patches were posted for review. WRT this particular change I don't personally like the idea of sharing gdt_frames[0] and gdt_ents for two semantically different usages, but I would defer to Jan as a hypervisor maintainer on that point. I don't much care about the gdt vs u naming for the union, although I would probably have gone with the more meaningful gdt if it were me. cscope-wise in emacs I would just use "C-c s t" to look for "gdt.size" etc. Ian.