From mboxrd@z Thu Jan 1 00:00:00 1970 From: Danny Al-Gaaf Subject: [PATCH 5/8] include/types.h: change operator<< function parameter Date: Tue, 5 Feb 2013 23:52:27 +0100 Message-ID: <1360104750-16098-6-git-send-email-danny.al-gaaf@bisect.de> References: <1360104750-16098-1-git-send-email-danny.al-gaaf@bisect.de> Return-path: Received: from wp188.webpack.hosteurope.de ([80.237.132.195]:50832 "EHLO wp188.webpack.hosteurope.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755710Ab3BEWwe (ORCPT ); Tue, 5 Feb 2013 17:52:34 -0500 In-Reply-To: <1360104750-16098-1-git-send-email-danny.al-gaaf@bisect.de> Sender: ceph-devel-owner@vger.kernel.org List-ID: To: ceph-devel@vger.kernel.org Cc: Danny Al-Gaaf , Sage Weil Fix "Function parameter 'v' should be passed by reference." from cppchecker. Use 'const pair& v' similar to the other operator<< in this file. Signed-off-by: Danny Al-Gaaf --- src/include/types.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/include/types.h b/src/include/types.h index c783b6e..dff47ac 100644 --- a/src/include/types.h +++ b/src/include/types.h @@ -120,7 +120,7 @@ namespace __gnu_cxx { // -- io helpers -- template -inline ostream& operator<<(ostream& out, const pair v) { +inline ostream& operator<<(ostream& out, const pair& v) { return out << v.first << "," << v.second; } -- 1.8.1.2