All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <Ian.Campbell@citrix.com>
To: David Miller <davem@davemloft.net>
Cc: "blp@cs.stanford.edu" <blp@cs.stanford.edu>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH 3/4] xen/netback: free already allocated memory on failure in xen_netbk_get_requests
Date: Thu, 7 Feb 2013 09:40:08 +0000	[thread overview]
Message-ID: <1360230008.32479.40.camel@zakaz.uk.xensource.com> (raw)
In-Reply-To: <20130206.134737.967342633025530520.davem@davemloft.net>

On Wed, 2013-02-06 at 18:47 +0000, David Miller wrote:
> From: Ben Pfaff <blp@cs.stanford.edu>
> Date: Wed, 06 Feb 2013 09:31:24 -0800
> 
> > Ian Campbell <ian.campbell@citrix.com> writes:
> > 
> >> +	/*
> >> +	 * Unwind, freeing all pages and sending error
> >> +	 * reponses.
> >> +	 */
> > 
> > s/reponses/responses/

Fixed, thanks!

> Also please format your comments in the standard networking form
> which is:
> 
> 	/* Like
> 	 * this.
> 	 */
> 
> Patch #1 has the same problem, thanks Ian.

I fixed this up, actually this particular one fits on a single line just
fine.

I'll resend shortly with the addition of the stable cc which I forgot
last time.

Thanks,
Ian.

  parent reply	other threads:[~2013-02-07  9:40 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-06 17:18 [PATCH 0/4] XSA-39 CVE-2013-021[67]: Linux netback DoS via malicious guest ring Ian Campbell
2013-02-06 17:18 ` [PATCH 1/4] xen/netback: shutdown the ring if it contains garbage Ian Campbell
2013-02-06 17:18 ` Ian Campbell
2013-02-06 17:18 ` [PATCH 2/4] xen/netback: don't leak pages on failure in xen_netbk_tx_check_gop Ian Campbell
2013-02-06 17:18 ` Ian Campbell
2013-02-06 17:18 ` [PATCH 3/4] xen/netback: free already allocated memory on failure in xen_netbk_get_requests Ian Campbell
2013-02-06 17:31   ` Ben Pfaff
2013-02-06 17:31   ` Ben Pfaff
2013-02-06 18:47     ` David Miller
2013-02-06 18:47     ` David Miller
2013-02-07  9:40       ` Ian Campbell
2013-02-07  9:40       ` Ian Campbell [this message]
2013-02-06 17:18 ` Ian Campbell
2013-02-06 17:18 ` [PATCH 4/4] netback: correct netbk_tx_err to handle wrap around Ian Campbell
2013-02-06 17:18 ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1360230008.32479.40.camel@zakaz.uk.xensource.com \
    --to=ian.campbell@citrix.com \
    --cc=blp@cs.stanford.edu \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.