From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932121Ab3BGP7s (ORCPT <rfc822;w@1wt.eu>);
	Thu, 7 Feb 2013 10:59:48 -0500
Received: from mailout39.mail01.mtsvc.net ([216.70.64.83]:40666 "EHLO
	n12.mail01.mtsvc.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org
	with ESMTP id S1756622Ab3BGP7q (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 7 Feb 2013 10:59:46 -0500
Message-ID: <1360252777.4102.42.camel@thor.lan>
Subject: Re: [PATCH v3 05/23] tty: Remove unnecessary re-test of ldisc ref
 count
From: Peter Hurley <peter@hurleysoftware.com>
To: Jiri Slaby <jslaby@suse.cz>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Alan Cox <alan@linux.intel.com>, Sasha Levin <levinsasha928@gmail.com>,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
        Ilya Zykov <ilya@ilyx.ru>, Dave Jones <davej@redhat.com>
Date: Thu, 07 Feb 2013 10:59:37 -0500
In-Reply-To: <5113C566.2060403@suse.cz>
References: <1355509370-5883-1-git-send-email-peter@hurleysoftware.com>
	 <1360095638-6624-1-git-send-email-peter@hurleysoftware.com>
	 <1360095638-6624-6-git-send-email-peter@hurleysoftware.com>
	 <5113C566.2060403@suse.cz>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.6.3-0pjh1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Authenticated-User: 125194 peter@hurleysoftware.com
X-MT-ID: 8fa290c2a27252aacf65dbc4a42f3ce3735fb2a4
X-MT-INTERNAL-ID: 8fa290c2a27252aacf65dbc4a42f3ce3735fb2a4
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 2013-02-07 at 16:16 +0100, Jiri Slaby wrote:
> On 02/05/2013 09:20 PM, Peter Hurley wrote:
> > +	char cur_n[TASK_COMM_LEN], tty_n[64];
> > +	long timeout = 3 * HZ;
> > +
> > +	if (tty->ldisc) {	/* Not yet closed */
> > +		tty_unlock(tty);
> > +
> > +		while (tty_ldisc_wait_idle(tty, timeout) == -EBUSY) {
> > +			timeout = MAX_SCHEDULE_TIMEOUT;
> > +			printk_ratelimited(KERN_WARNING
> > +				"%s: waiting (%s) for %s took too long, but we keep waiting...\n",
> > +				__func__, get_task_comm(cur_n, current),
> > +				tty_name(tty, tty_n));
> >  		}
> > -		break;
> > +		/* must reacquire both locks and preserve lock order */
> > +		mutex_unlock(&tty->ldisc_mutex);
> > +		tty_lock(tty);
> > +		mutex_lock(&tty->ldisc_mutex);
> >  	}
> >  	return !!(tty->ldisc);
                   ^^^^^^^^^^^^
               still want me to fix this though?

> >  }
> 
> Ok, so you do it here. So we can silently ignore the comment on 04/23...