All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Pirko <jiri@resnulli.us>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, edumazet@google.com, jhs@mojatatu.com,
	kuznet@ms2.inr.ac.ru
Subject: [patch net-next 3/7] htb: remove pointless first initialization of buffer and cbuffer
Date: Fri,  8 Feb 2013 13:58:43 +0100	[thread overview]
Message-ID: <1360328327-7144-4-git-send-email-jiri@resnulli.us> (raw)
In-Reply-To: <1360328327-7144-1-git-send-email-jiri@resnulli.us>

these are initialized correctly couple of lines later in the function.

Signed-off-by: Jiri Pirko <jiri@resnulli.us>
---
 net/sched/sch_htb.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/net/sched/sch_htb.c b/net/sched/sch_htb.c
index 14a83dc..547912e9 100644
--- a/net/sched/sch_htb.c
+++ b/net/sched/sch_htb.c
@@ -1503,9 +1503,6 @@ static int htb_change_class(struct Qdisc *sch, u32 classid,
 			cl->prio = TC_HTB_NUMPRIO - 1;
 	}
 
-	cl->buffer = hopt->buffer;
-	cl->cbuffer = hopt->cbuffer;
-
 	cl->rate.rate_bps = (u64)hopt->rate.rate << 3;
 	cl->ceil.rate_bps = (u64)hopt->ceil.rate << 3;
 
-- 
1.8.1.2

  parent reply	other threads:[~2013-02-08 12:58 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-08 12:58 [patch net-next 0/7] couple of net/sched fixes+improvements Jiri Pirko
2013-02-08 12:58 ` [patch net-next 1/7] htb: use PSCHED_TICKS2NS() Jiri Pirko
2013-02-08 15:51   ` Eric Dumazet
2013-02-08 12:58 ` [patch net-next 2/7] htb: fix values in opt dump Jiri Pirko
2013-02-08 15:54   ` Eric Dumazet
2013-02-08 16:02     ` Jiri Pirko
2013-02-08 12:58 ` Jiri Pirko [this message]
2013-02-08 16:35   ` [patch net-next 3/7] htb: remove pointless first initialization of buffer and cbuffer Eric Dumazet
2013-02-08 12:58 ` [patch net-next 4/7] htb: initialize cl->tokens and cl->ctokens correctly Jiri Pirko
2013-02-08 16:36   ` Eric Dumazet
2013-02-08 12:58 ` [patch net-next 5/7] sch: make htb_rate_cfg and functions around that generic Jiri Pirko
2013-02-08 16:39   ` Eric Dumazet
2013-02-08 12:58 ` [patch net-next 6/7] tbf: improved accuracy at high rates Jiri Pirko
2013-02-08 16:42   ` Eric Dumazet
2013-02-08 12:58 ` [patch net-next 7/7] tbf: ignore max_size check for gso skbs Jiri Pirko
2013-02-08 16:43   ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1360328327-7144-4-git-send-email-jiri@resnulli.us \
    --to=jiri@resnulli.us \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=jhs@mojatatu.com \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.