All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <Ian.Campbell@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Boris Ostrovsky <boris.ostrovsky@amd.com>,
	Sherry Hurwitz <sherry.hurwitz@amd.com>,
	xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH 2/2] AMD IOMMU: handle MSI for phantom functions
Date: Mon, 11 Feb 2013 10:53:38 +0000	[thread overview]
Message-ID: <1360580018.29432.104.camel@zakaz.uk.xensource.com> (raw)
In-Reply-To: <511264DA02000078000BC758@nat28.tlf.novell.com>

On Wed, 2013-02-06 at 13:12 +0000, Jan Beulich wrote:
> @@ -379,12 +382,30 @@ void amd_iommu_msi_msg_update_ire(
>      }
>  
>      if ( msi_desc->remap_index >= 0 )
> -        update_intremap_entry_from_msi_msg(iommu, bdf, msi_desc, NULL);
> +    {
> +        do {
> +            update_intremap_entry_from_msi_msg(iommu, bdf,
> +                                               &msi_desc->remap_index, NULL);
> +            if ( !pdev || !pdev->phantom_stride )
> +                break;
> +            bdf += pdev->phantom_stride;
> +        } while ( PCI_SLOT(bdf) == PCI_SLOT(pdev->devfn) );
> +
> +        msi_desc->remap_index = -1;

The reason for this reset is a bit subtle, but I think I get it, might
be worth a comment though.

Otherwise: Acked-by: Ian Campbell <ian.campbell@citrix.com>
(although with similar caveats to 1/2)

Ian.

  reply	other threads:[~2013-02-11 10:53 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-06 13:04 [PATCH 0/2] AMD IOMMU: XSA-36 follow ups Jan Beulich
2013-02-06 13:12 ` [PATCH 1/2] AMD IOMMU: also spot missing IO-APIC entries in IVRS table Jan Beulich
2013-02-06 14:41   ` Boris Ostrovsky
2013-02-06 14:52     ` Jan Beulich
2013-02-06 15:03       ` Boris Ostrovsky
2013-02-06 15:12         ` Jan Beulich
2013-02-11 10:49   ` Ian Campbell
2013-02-12 11:59     ` Jan Beulich
2013-02-06 13:12 ` [PATCH 2/2] AMD IOMMU: handle MSI for phantom functions Jan Beulich
2013-02-11 10:53   ` Ian Campbell [this message]
2013-02-08  9:58 ` [PATCH 0/2] AMD IOMMU: XSA-36 follow ups Jan Beulich
2013-02-08 13:53   ` Sander Eikelenboom
2013-03-01 18:45   ` Malcolm Crossley
2013-03-04  9:48     ` Jan Beulich
2013-02-11 13:12 ` Ian Campbell
2013-02-12  8:45   ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1360580018.29432.104.camel@zakaz.uk.xensource.com \
    --to=ian.campbell@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=boris.ostrovsky@amd.com \
    --cc=sherry.hurwitz@amd.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.