From: Joe Perches <joe@perches.com>
To: Solomon Peachy <pizza@shaftnet.org>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 01/14] cw1200: v4: low-level hardware I/O functions
Date: Mon, 11 Feb 2013 11:01:35 -0800 [thread overview]
Message-ID: <1360609295.2028.44.camel@joe-AO722> (raw)
In-Reply-To: <20130211185322.GB3123@shaftnet.org>
On Mon, 2013-02-11 at 13:53 -0500, Solomon Peachy wrote:
> On Fri, Feb 08, 2013 at 05:15:59PM -0800, Joe Perches wrote:
> > Could you please run your patches through
> > scripts/checkpatch.pl --strict
>
> If you think it's bad now, you should have seen the state of the code
> when I first "inherited" it. :)
No doubt, but that wasn't my point.
> Question -- as a matter of policy, is the goal to have a completely
> clean checkpatch run? I get that there should be no ERRORs, but
> WARNINGs/CHECKs are not considered fatal for a reason, right?
No. It's just a guideline. As far as I'm concerned,
ignore every checkpatch message you don't agree with.
Just be aware that there's a tool to help you get your
code looking more like what most others generally consider
"kernel style".
Though when you add "new" code, stuff like
> + u32 sdio_reg_addr_17bit ;
is untidy because of the space before the semicolon.
next prev parent reply other threads:[~2013-02-11 19:01 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-08 20:31 RFCv4: ST-E CW1100/1200 WLAN driver Solomon Peachy
2013-02-08 20:31 ` [PATCH 01/14] cw1200: v4: low-level hardware I/O functions Solomon Peachy
2013-02-09 1:15 ` Joe Perches
2013-02-11 18:53 ` Solomon Peachy
2013-02-11 19:01 ` Joe Perches [this message]
2013-02-11 19:25 ` Solomon Peachy
2013-02-12 13:35 ` Kalle Valo
2013-02-12 14:40 ` Joe Perches
2013-02-11 19:07 ` Solomon Peachy
2013-02-11 19:29 ` [PATCH] scripts: Remove Lindent and suggestions to use it Joe Perches
2013-02-08 20:31 ` [PATCH 02/14] cw1200: v4: Internal TX queue handling and tracking Solomon Peachy
2013-02-08 20:31 ` [PATCH 03/14] cw1200: v4: Scanning implementation Solomon Peachy
2013-02-08 20:31 ` [PATCH 04/14] cw1200: v4: Power Management (WoWLAN) Solomon Peachy
2013-02-08 20:31 ` [PATCH 05/14] cw1200: v4: Firmware loading Solomon Peachy
2013-02-08 20:31 ` [PATCH 06/14] cw1200: v4: Debugging hooks and test tool support Solomon Peachy
2013-02-08 20:32 ` [PATCH 07/14] cw1200: v4: mac80211 API implementation Solomon Peachy
2013-02-08 20:32 ` [PATCH 08/14] cw1200: v4: Packet TX/RX Solomon Peachy
2013-02-08 20:32 ` [PATCH 09/14] cw1200: v4: WSM (host-firmware) interface Solomon Peachy
2013-02-08 20:32 ` [PATCH 10/14] cw1200: v4: Main processing loop Solomon Peachy
2013-02-08 20:32 ` [PATCH 11/14] cw1200: v4: common state, definitions, and registration handling Solomon Peachy
2013-02-08 20:32 ` [PATCH 12/14] cw1200: v4: SDIO and SPI glue code and platform definitions Solomon Peachy
2013-02-08 20:32 ` [PATCH 13/14] cw1200: v4: Kbuild integration Solomon Peachy
2013-02-08 20:32 ` [PATCH 14/14] cw1200: v4: Add to drivers/net/wireless kbuild, plus MAINTAINERS entry Solomon Peachy
2013-02-08 20:36 ` RFCv4: ST-E CW1100/1200 WLAN driver Johannes Berg
2013-02-14 15:58 ` Solomon Peachy
2013-03-20 8:10 ` Bartosz Markowski
2013-03-20 11:53 ` Solomon Peachy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360609295.2028.44.camel@joe-AO722 \
--to=joe@perches.com \
--cc=linux-wireless@vger.kernel.org \
--cc=pizza@shaftnet.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.