Re: [PATCH v2] sched: fix wrong rq's runnable_avg update with rt task

From: Steven Rostedt <rostedt@goodmis.org>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: linux-kernel@vger.kernel.org, linaro-dev@lists.linaro.org,
	peterz@infradead.org, mingo@kernel.org, fweisbec@gmail.com,
	efault@gmx.de
Subject: Re: [PATCH v2] sched: fix wrong rq's runnable_avg update with rt task
Date: Tue, 12 Feb 2013 09:53:08 -0500	[thread overview]
Message-ID: <1360680788.21867.9.camel@gandalf.local.home> (raw)
In-Reply-To: <1360675434-4259-1-git-send-email-vincent.guittot@linaro.org>

On Tue, 2013-02-12 at 14:23 +0100, Vincent Guittot wrote:
> 	.set_curr_task          = set_curr_task_idle,
> diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
> index fc88644..9707092 100644
> --- a/kernel/sched/sched.h
> +++ b/kernel/sched/sched.h
> @@ -877,6 +877,7 @@ extern const struct sched_class idle_sched_class;
>  
>  extern void trigger_load_balance(struct rq *rq, int cpu);
>  extern void idle_balance(int this_cpu, struct rq *this_rq);
> +extern void idle_exit(int this_cpu, struct rq *this_rq);
>  
>  #else	/* CONFIG_SMP */
>  
> @@ -884,6 +885,10 @@ static inline void idle_balance(int cpu, struct rq *rq)
>  {
>  }
>  
> +static inline void idle_exit(int this_cpu, struct rq *this_rq)
> +{
> +}
> +

Is this part needed? I don't see it ever called when !CONFIG_SMP.

-- Steve

>  #endif
>  
>  extern void sysrq_sched_debug_show(void);