All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Chris Larson <clarson@kergoth.com>, Martin Ertsaas <martiert@gmail.com>
Cc: bitbake-devel <bitbake-devel@lists.openembedded.org>
Subject: Re: [PATCH] utils: Use rm -rf in remove()
Date: Fri, 15 Feb 2013 16:00:17 +0000	[thread overview]
Message-ID: <1360944017.31795.1.camel@ted> (raw)
In-Reply-To: <CABcZANmd9_bcAUizAR3JiSX368HJsKhzGrGPkqAsbMsw2G9=ig@mail.gmail.com>

On Thu, 2013-02-07 at 18:08 -0700, Chris Larson wrote:
> 
> On Thu, Feb 7, 2013 at 4:55 PM, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
>         -                shutil.rmtree(name)
>         +                # shutil.rmtree(name) would be ideal but its
>         too slow
>         +                subprocess.call('rm -rf %s' % path,
>         shell=True)
> 
> This is a good idea, but I'm curious about forking off a shell process
> for it. I'd think this would work as well: subprocess.call(['rm',
> '-rf', path])

path can have wildcards in it. The code wasn't entirely obvious so I've
tweaked it after your/Peter's comments. I'm hoping it will help the
problems Martin was seeing too.

Cheers,

Richard





  reply	other threads:[~2013-02-15 16:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-07 23:55 [PATCH] utils: Use rm -rf in remove() Richard Purdie
2013-02-08  1:08 ` Chris Larson
2013-02-15 16:00   ` Richard Purdie [this message]
2013-02-16 13:51     ` Martin Ertsås
2013-02-16 14:54       ` Richard Purdie
2013-02-16 15:27         ` Martin Ertsås
2013-02-08 13:47 ` Peter Kjellerstedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1360944017.31795.1.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=bitbake-devel@lists.openembedded.org \
    --cc=clarson@kergoth.com \
    --cc=martiert@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.