From: anish kumar <anish198519851985@gmail.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: Don Zickus <dzickus@redhat.com>,
akpm@linux-foundation.org, tglx@linutronix.de,
chuansheng.liu@intel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [Watchdog][Trivial] Added comments to explain watchdog_disabled variable
Date: Sat, 16 Feb 2013 17:08:45 +0530 [thread overview]
Message-ID: <1361014725.1672.0.camel@anish-Inspiron-N5050> (raw)
In-Reply-To: <20130216084245.GD18953@gmail.com>
On Sat, 2013-02-16 at 09:42 +0100, Ingo Molnar wrote:
> * Don Zickus <dzickus@redhat.com> wrote:
>
> > > >> > + /*
> > > >> > + * We shouldn't enable watchdog threads if it is
> > > >> > + * disabled.This is done by watchdog_disabled
> > > >> > + * variable check in watchdog_*_all_cpus function.
> > > >
> > > > It has two grammatic and a stylistic error in it, plus misses
> > > Would you mind pointing it out to me the grammatical mistakes
> > > as I am not that good with grammar.
> >
> > I am not entirely sure which ones Ingo is referring to, but what I see are
> >
> > 'disabled.This' needs a space after period
> > 'This is done by watchdog_disabled' needs a 'the' after 'by'
> > 'variable check in watchdog..' needs a 'the' after 'in'.
> >
> > in addition to the missing ()'s after 'watchdog_*_all_cpus.
>
> There's also a plural/singular mismatch between 'watchdog
> threads' and 'if it is disabled'.
Thanks, I will update the same in the next patch.
>
> Thanks,
>
> Ingo
next prev parent reply other threads:[~2013-02-16 11:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-03 16:01 [PATCH] [Watchdog][Trivial] Added comments to explain watchdog_disabled variable anish kumar
2013-02-13 7:17 ` anish singh
2013-02-13 9:21 ` Ingo Molnar
2013-02-13 9:58 ` anish singh
2013-02-15 16:29 ` Don Zickus
2013-02-16 8:42 ` Ingo Molnar
2013-02-16 11:38 ` anish kumar [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-02-16 12:14 anish kumar
2013-02-18 20:48 ` Don Zickus
2013-03-06 11:47 ` anish singh
2013-03-07 15:40 ` Don Zickus
2013-02-01 13:49 anish kumar
2013-02-01 14:59 ` Don Zickus
2013-02-02 3:16 ` anish kumar
2013-02-01 13:33 anish kumar
2013-02-01 13:50 ` anish kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1361014725.1672.0.camel@anish-Inspiron-N5050 \
--to=anish198519851985@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=chuansheng.liu@intel.com \
--cc=dzickus@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.