All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Henningsson <david.henningsson@canonical.com>
To: tiwai@suse.de, alsa-devel@alsa-project.org,
	fengguang.wu@intel.com, pierre-louis.bossart@linux.intel.com
Cc: David Henningsson <david.henningsson@canonical.com>
Subject: [PATCH 1/3] ALSA: hda - hdmi: ELD shouldn't be valid after unplug
Date: Mon, 18 Feb 2013 14:11:11 +0100	[thread overview]
Message-ID: <1361193073-7199-2-git-send-email-david.henningsson@canonical.com> (raw)
In-Reply-To: <1361193073-7199-1-git-send-email-david.henningsson@canonical.com>

Currently, eld_valid is never set to false, except at kernel module
load time. This patch makes sure that eld is no longer valid when
the cable is (hot-)unplugged.

Signed-off-by: David Henningsson <david.henningsson@canonical.com>
---
 sound/pci/hda/patch_hdmi.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
index b9af281b..32adaa6 100644
--- a/sound/pci/hda/patch_hdmi.c
+++ b/sound/pci/hda/patch_hdmi.c
@@ -1176,6 +1176,7 @@ static void hdmi_present_sense(struct hdmi_spec_per_pin *per_pin, int repoll)
 		"HDMI status: Codec=%d Pin=%d Presence_Detect=%d ELD_Valid=%d\n",
 		codec->addr, pin_nid, eld->monitor_present, eld_valid);
 
+	eld->eld_valid = false;
 	if (eld_valid) {
 		if (!snd_hdmi_get_eld(eld, codec, pin_nid))
 			snd_hdmi_show_eld(eld);
-- 
1.7.9.5

  reply	other threads:[~2013-02-18 13:11 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-18 13:11 [PATCH 0/3] Make HDMI ELD usable with hotplug David Henningsson
2013-02-18 13:11 ` David Henningsson [this message]
2013-02-18 13:11 ` [PATCH 2/3] ALSA: hda - hdmi: Do not expose eld data when eld is invalid David Henningsson
2013-02-18 14:39   ` Takashi Iwai
2013-02-18 13:11 ` [PATCH 3/3] ALSA: hda - hdmi: Notify userspace when ELD control changes David Henningsson
2013-02-18 14:41   ` Takashi Iwai
2013-02-18 14:46     ` David Henningsson
2013-02-18 14:55       ` Takashi Iwai
2013-02-18 15:09         ` David Henningsson
2013-02-18 15:14           ` Takashi Iwai
2013-02-18 16:08             ` David Henningsson
2013-02-18 16:21               ` Takashi Iwai
2013-02-18 13:35 ` [PATCH 0/3] Make HDMI ELD usable with hotplug Takashi Iwai
2013-02-18 13:50   ` David Henningsson
2013-02-18 14:28     ` Takashi Iwai
2013-02-18 14:33       ` Takashi Iwai
2013-02-18 22:39     ` Ville Syrjälä
2013-02-19  2:39       ` Wang xingchao
2013-02-19  5:55       ` David Henningsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1361193073-7199-2-git-send-email-david.henningsson@canonical.com \
    --to=david.henningsson@canonical.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=fengguang.wu@intel.com \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.