* [PATCH v5 1/5] ARM: dts: Add FIMD node to exynos4
2013-02-27 8:43 [PATCH v5 0/5] Add DRM FIMD DT support for Exynos4 DT Machines Vikas Sajjan
@ 2013-02-27 8:43 ` Vikas Sajjan
2013-02-27 8:43 ` [PATCH v5 2/5] ARM: dts: Add lcd pinctrl node entries for EXYNOS4412 SoC Vikas Sajjan
` (3 subsequent siblings)
4 siblings, 0 replies; 8+ messages in thread
From: Vikas Sajjan @ 2013-02-27 8:43 UTC (permalink / raw)
To: linux-samsung-soc
Cc: kgene.kim, inki.dae, t.figa, sylvester.nawrocki,
devicetree-discuss, sachin.kamat, joshi
This adds common FIMD device node for all Exynos4 SoCs.
Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org>
---
arch/arm/boot/dts/exynos4.dtsi | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
index 6581bb2..416a639 100644
--- a/arch/arm/boot/dts/exynos4.dtsi
+++ b/arch/arm/boot/dts/exynos4.dtsi
@@ -297,4 +297,11 @@
interrupts = <0 34 0>;
};
};
+
+ fimd: fimd@11c00000 {
+ compatible = "samsung,exynos4210-fimd";
+ interrupt-parent = <&combiner>;
+ reg = <0x11c00000 0x20000>;
+ interrupts = <11 1>, <11 0>, <11 2>;
+ };
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v5 2/5] ARM: dts: Add lcd pinctrl node entries for EXYNOS4412 SoC
2013-02-27 8:43 [PATCH v5 0/5] Add DRM FIMD DT support for Exynos4 DT Machines Vikas Sajjan
2013-02-27 8:43 ` [PATCH v5 1/5] ARM: dts: Add FIMD node to exynos4 Vikas Sajjan
@ 2013-02-27 8:43 ` Vikas Sajjan
2013-02-27 8:43 ` [PATCH v5 3/5] ARM: dts: Add FIMD node and display timing node to exynos4412-origen.dts Vikas Sajjan
` (2 subsequent siblings)
4 siblings, 0 replies; 8+ messages in thread
From: Vikas Sajjan @ 2013-02-27 8:43 UTC (permalink / raw)
To: linux-samsung-soc
Cc: kgene.kim, inki.dae, t.figa, sylvester.nawrocki,
devicetree-discuss, sachin.kamat, joshi
From: Sachin Kamat <sachin.kamat@linaro.org>
This patch adds the lcd panel related picntrl nodes for Exynos4412 SoC
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org>
---
arch/arm/boot/dts/exynos4x12-pinctrl.dtsi | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/arch/arm/boot/dts/exynos4x12-pinctrl.dtsi b/arch/arm/boot/dts/exynos4x12-pinctrl.dtsi
index 099cec7..a59d69c 100644
--- a/arch/arm/boot/dts/exynos4x12-pinctrl.dtsi
+++ b/arch/arm/boot/dts/exynos4x12-pinctrl.dtsi
@@ -354,6 +354,20 @@
samsung,pin-drv = <0>;
};
+ lcd_sync: lcd-sync {
+ samsung,pins = "gpf0-0", "gpf0-1";
+ samsung,pin-function = <2>;
+ samsung,pin-pud = <0>;
+ samsung,pin-drv = <0>;
+ };
+
+ lcd_en: lcd-en {
+ samsung,pins = "gpf0-3";
+ samsung,pin-function = <2>;
+ samsung,pin-pud = <0>;
+ samsung,pin-drv = <0>;
+ };
+
lcd_clk: lcd-clk {
samsung,pins = "gpf0-0", "gpf0-1", "gpf0-2", "gpf0-3";
samsung,pin-function = <2>;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v5 3/5] ARM: dts: Add FIMD node and display timing node to exynos4412-origen.dts
2013-02-27 8:43 [PATCH v5 0/5] Add DRM FIMD DT support for Exynos4 DT Machines Vikas Sajjan
2013-02-27 8:43 ` [PATCH v5 1/5] ARM: dts: Add FIMD node to exynos4 Vikas Sajjan
2013-02-27 8:43 ` [PATCH v5 2/5] ARM: dts: Add lcd pinctrl node entries for EXYNOS4412 SoC Vikas Sajjan
@ 2013-02-27 8:43 ` Vikas Sajjan
2013-02-27 8:43 ` [PATCH v5 4/5] ARM: dts: add FIMD AUXDATA node entry for exynos4 DT Vikas Sajjan
2013-02-27 8:43 ` [PATCH v5 5/5] ARM: exynos: dts: Add FIMD DT binding Documentation Vikas Sajjan
4 siblings, 0 replies; 8+ messages in thread
From: Vikas Sajjan @ 2013-02-27 8:43 UTC (permalink / raw)
To: linux-samsung-soc
Cc: kgene.kim, inki.dae, t.figa, sylvester.nawrocki,
devicetree-discuss, sachin.kamat, joshi
Adds FIMD DT support to Origen quad board
Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org>
---
arch/arm/boot/dts/exynos4412-origen.dts | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
diff --git a/arch/arm/boot/dts/exynos4412-origen.dts b/arch/arm/boot/dts/exynos4412-origen.dts
index 31e14c4..a6fd41f 100644
--- a/arch/arm/boot/dts/exynos4412-origen.dts
+++ b/arch/arm/boot/dts/exynos4412-origen.dts
@@ -70,6 +70,28 @@
status = "okay";
};
+ fimd@11c00000 {
+ samsung,power-domain = <&pd_lcd0>;
+ pinctrl-0 = <&lcd_sync &lcd_clk &lcd_en &lcd_data24 &pwm1_out>;
+ pinctrl-names = "default";
+ status = "okay";
+ };
+
+ display-timings {
+ native-mode = <&timing0>;
+ timing0: timing@0 {
+ clock-frequency = <50000>;
+ hactive = <1024>;
+ vactive = <600>;
+ hfront-porch = <64>;
+ hback-porch = <16>;
+ hsync-len = <48>;
+ vback-porch = <64>;
+ vfront-porch = <16>;
+ vsync-len = <3>;
+ };
+ };
+
serial@13800000 {
status = "okay";
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v5 4/5] ARM: dts: add FIMD AUXDATA node entry for exynos4 DT
2013-02-27 8:43 [PATCH v5 0/5] Add DRM FIMD DT support for Exynos4 DT Machines Vikas Sajjan
` (2 preceding siblings ...)
2013-02-27 8:43 ` [PATCH v5 3/5] ARM: dts: Add FIMD node and display timing node to exynos4412-origen.dts Vikas Sajjan
@ 2013-02-27 8:43 ` Vikas Sajjan
2013-02-27 8:43 ` [PATCH v5 5/5] ARM: exynos: dts: Add FIMD DT binding Documentation Vikas Sajjan
4 siblings, 0 replies; 8+ messages in thread
From: Vikas Sajjan @ 2013-02-27 8:43 UTC (permalink / raw)
To: linux-samsung-soc
Cc: kgene.kim, inki.dae, t.figa, sylvester.nawrocki,
devicetree-discuss, sachin.kamat, joshi
Adds the FIMD AUXDATA node
Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org>
---
arch/arm/mach-exynos/mach-exynos4-dt.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/mach-exynos/mach-exynos4-dt.c b/arch/arm/mach-exynos/mach-exynos4-dt.c
index b68115a..b32a929 100644
--- a/arch/arm/mach-exynos/mach-exynos4-dt.c
+++ b/arch/arm/mach-exynos/mach-exynos4-dt.c
@@ -84,6 +84,8 @@ static const struct of_dev_auxdata exynos4_auxdata_lookup[] __initconst = {
OF_DEV_AUXDATA("samsung,exynos4210-tmu", EXYNOS4_PA_TMU,
"exynos-tmu", NULL),
OF_DEV_AUXDATA("samsung,mfc-v5", 0x13400000, "s5p-mfc", NULL),
+ OF_DEV_AUXDATA("samsung,exynos4210-fimd", EXYNOS4_PA_FIMD0,
+ "exynos4-fb.0", NULL),
{},
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v5 5/5] ARM: exynos: dts: Add FIMD DT binding Documentation
2013-02-27 8:43 [PATCH v5 0/5] Add DRM FIMD DT support for Exynos4 DT Machines Vikas Sajjan
` (3 preceding siblings ...)
2013-02-27 8:43 ` [PATCH v5 4/5] ARM: dts: add FIMD AUXDATA node entry for exynos4 DT Vikas Sajjan
@ 2013-02-27 8:43 ` Vikas Sajjan
2013-02-28 6:12 ` Sachin Kamat
4 siblings, 1 reply; 8+ messages in thread
From: Vikas Sajjan @ 2013-02-27 8:43 UTC (permalink / raw)
To: linux-samsung-soc
Cc: kgene.kim, inki.dae, t.figa, sylvester.nawrocki,
devicetree-discuss, sachin.kamat, joshi
Adds FIMD DT binding documentation both SoC and Board, with an example
Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org>
---
.../devicetree/bindings/video/exynos-fimd.txt | 46 ++++++++++++++++++++
1 file changed, 46 insertions(+)
create mode 100644 Documentation/devicetree/bindings/video/exynos-fimd.txt
diff --git a/Documentation/devicetree/bindings/video/exynos-fimd.txt b/Documentation/devicetree/bindings/video/exynos-fimd.txt
new file mode 100644
index 0000000..b3542b9
--- /dev/null
+++ b/Documentation/devicetree/bindings/video/exynos-fimd.txt
@@ -0,0 +1,46 @@
+Device-Tree bindings for Exynos SoC display controller (FIMD)
+
+FIMD stands for Fully Interactive Mobile Display, is the Display Controller for
+the Exynos series of SoCs which transfers the image data from a video buffer
+located in the system memory to an external LCD interface.
+
+Required properties:
+- compatible := value can be one these below
+ "samsung,s3c2443-fimd"; /* for S3C24XX SoCs */
+ "samsung,s3c6400-fimd"; /* for S3C64XX SoCs */
+ "samsung,s5p6440-fimd"; /* for S5P64X0 SoCs */
+ "samsung,s5pc100-fimd"; /* for S5PC100 SoC */
+ "samsung,s5pv210-fimd"; /* for S5PV210 SoC */
+ "samsung,exynos4210-fimd"; /* for Exynos4 SoCs */
+ "samsung,exynos5250-fimd"; /* for Exynos5 SoCs */
+- reg := physical base address of the fimd and length of memory mapped region
+- interrupt-parent := reference to the interrupt combiner node with phandle
+- interrupts := interrupt number from the combiner to the cpu
+ we have 3 interrupts and the Interrupt combiner order is
+ FIFO Level, VSYNC and LCD_SYSTEM. Make sure to mention order
+ as VSYNC, FIFO Level and LCD_SYSTEM as show in the example below.
+- pinctrl := property defining the pinctrl configurations with a phandle
+- pinctrl-names := name of the pinctrl
+
+Optional Properties:
+- samsung,power-domain := power domain property defined with a phandle
+
+Example:
+
+SoC specific DT Entry:
+
+ fimd@11c00000 {
+ compatible = "samsung,exynos4210-fimd";
+ interrupt-parent = <&combiner>;
+ reg = <0x11c00000 0x20000>;
+ interrupts = <11 1>, <11 0>, <11 2>;
+ };
+
+Board specific DT Entry:
+
+ fimd@11c00000 {
+ samsung,power-domain = <&pd_lcd0>;
+ pinctrl-0 = <&lcd_sync &lcd_clk &lcd_en &lcd0_data &pwm1_out>;
+ pinctrl-names = "default";
+ status = "okay";
+ };
--
1.7.9.5
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v5 5/5] ARM: exynos: dts: Add FIMD DT binding Documentation
2013-02-27 8:43 ` [PATCH v5 5/5] ARM: exynos: dts: Add FIMD DT binding Documentation Vikas Sajjan
@ 2013-02-28 6:12 ` Sachin Kamat
2013-02-28 6:37 ` Vikas Sajjan
0 siblings, 1 reply; 8+ messages in thread
From: Sachin Kamat @ 2013-02-28 6:12 UTC (permalink / raw)
To: Vikas Sajjan
Cc: linux-samsung-soc, kgene.kim, inki.dae, t.figa,
sylvester.nawrocki, devicetree-discuss, joshi
Hi Vikas,
On 27 February 2013 14:13, Vikas Sajjan <vikas.sajjan@linaro.org> wrote:
> Adds FIMD DT binding documentation both SoC and Board, with an example
>
> Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org>
> ---
> .../devicetree/bindings/video/exynos-fimd.txt | 46 ++++++++++++++++++++
> 1 file changed, 46 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/video/exynos-fimd.txt
>
> diff --git a/Documentation/devicetree/bindings/video/exynos-fimd.txt b/Documentation/devicetree/bindings/video/exynos-fimd.txt
> new file mode 100644
> index 0000000..b3542b9
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/video/exynos-fimd.txt
> @@ -0,0 +1,46 @@
> +Device-Tree bindings for Exynos SoC display controller (FIMD)
> +
> +FIMD stands for Fully Interactive Mobile Display, is the Display Controller for
> +the Exynos series of SoCs which transfers the image data from a video buffer
I think this should be Samsung series of SoCs intead of Exynos series.
As such the file name could be samsung-fimd.txt.
> +located in the system memory to an external LCD interface.
> +
> +Required properties:
> +- compatible := value can be one these below
"value should be one of the following:"
> + "samsung,s3c2443-fimd"; /* for S3C24XX SoCs */
> + "samsung,s3c6400-fimd"; /* for S3C64XX SoCs */
> + "samsung,s5p6440-fimd"; /* for S5P64X0 SoCs */
> + "samsung,s5pc100-fimd"; /* for S5PC100 SoC */
> + "samsung,s5pv210-fimd"; /* for S5PV210 SoC */
> + "samsung,exynos4210-fimd"; /* for Exynos4 SoCs */
> + "samsung,exynos5250-fimd"; /* for Exynos5 SoCs */
blank line here would make it more readable?
> +- reg := physical base address of the fimd and length of memory mapped region
> +- interrupt-parent := reference to the interrupt combiner node with phandle
> +- interrupts := interrupt number from the combiner to the cpu
> + we have 3 interrupts and the Interrupt combiner order is
> + FIFO Level, VSYNC and LCD_SYSTEM. Make sure to mention order
> + as VSYNC, FIFO Level and LCD_SYSTEM as show in the example below.
Please rephrase the above as there seems to be difference in order in
the above 2 lines itself. :)
--
With warm regards,
Sachin
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v5 5/5] ARM: exynos: dts: Add FIMD DT binding Documentation
2013-02-28 6:12 ` Sachin Kamat
@ 2013-02-28 6:37 ` Vikas Sajjan
0 siblings, 0 replies; 8+ messages in thread
From: Vikas Sajjan @ 2013-02-28 6:37 UTC (permalink / raw)
To: Sachin Kamat
Cc: linux-samsung-soc, kgene.kim, inki.dae, t.figa,
sylvester.nawrocki, devicetree-discuss, joshi
Hi Sachin,
On 28 February 2013 11:42, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> Hi Vikas,
>
> On 27 February 2013 14:13, Vikas Sajjan <vikas.sajjan@linaro.org> wrote:
>> Adds FIMD DT binding documentation both SoC and Board, with an example
>>
>> Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org>
>> ---
>> .../devicetree/bindings/video/exynos-fimd.txt | 46 ++++++++++++++++++++
>> 1 file changed, 46 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/video/exynos-fimd.txt
>>
>> diff --git a/Documentation/devicetree/bindings/video/exynos-fimd.txt b/Documentation/devicetree/bindings/video/exynos-fimd.txt
>> new file mode 100644
>> index 0000000..b3542b9
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/video/exynos-fimd.txt
>> @@ -0,0 +1,46 @@
>> +Device-Tree bindings for Exynos SoC display controller (FIMD)
>> +
>> +FIMD stands for Fully Interactive Mobile Display, is the Display Controller for
>> +the Exynos series of SoCs which transfers the image data from a video buffer
>
> I think this should be Samsung series of SoCs intead of Exynos series.
> As such the file name could be samsung-fimd.txt.
Right.
>
>> +located in the system memory to an external LCD interface.
>> +
>> +Required properties:
>> +- compatible := value can be one these below
>
> "value should be one of the following:"
Ok.
>
>
>> + "samsung,s3c2443-fimd"; /* for S3C24XX SoCs */
>> + "samsung,s3c6400-fimd"; /* for S3C64XX SoCs */
>> + "samsung,s5p6440-fimd"; /* for S5P64X0 SoCs */
>> + "samsung,s5pc100-fimd"; /* for S5PC100 SoC */
>> + "samsung,s5pv210-fimd"; /* for S5PV210 SoC */
>> + "samsung,exynos4210-fimd"; /* for Exynos4 SoCs */
>> + "samsung,exynos5250-fimd"; /* for Exynos5 SoCs */
>
> blank line here would make it more readable?
>
>> +- reg := physical base address of the fimd and length of memory mapped region
>> +- interrupt-parent := reference to the interrupt combiner node with phandle
>> +- interrupts := interrupt number from the combiner to the cpu
>> + we have 3 interrupts and the Interrupt combiner order is
>> + FIFO Level, VSYNC and LCD_SYSTEM. Make sure to mention order
>> + as VSYNC, FIFO Level and LCD_SYSTEM as show in the example below.
>
> Please rephrase the above as there seems to be difference in order in
> the above 2 lines itself. :)
what it means is the Interrupt combiner order is : FIFO Level, VSYNC
and LCD_SYSTEM
but since we use only the VSYNC interrupt and in the driver while
getting IRQ number we pass 0 as index,
hence the documentation says
Make sure to mention order as VSYNC, FIFO Level and LCD_SYSTEM, as
show in the example below
interrupts = <11 1>, <11 0>, <11 2>;
>
>
> --
> With warm regards,
> Sachin
--
Thanks and Regards
Vikas Sajjan
^ permalink raw reply [flat|nested] 8+ messages in thread