From: Christian Babeux <christian.babeux@efficios.com>
To: dgoulet@efficios.com
Cc: lttng-dev@lists.lttng.org
Subject: [PATCH lttng-tools] Fix: Use after free on spawn_sessiond error path in check_sessiond
Date: Thu, 28 Feb 2013 15:48:30 -0500 [thread overview]
Message-ID: <1362084510-10072-7-git-send-email-christian.babeux__32251.3043917299$1362084617$gmane$org@efficios.com> (raw)
In-Reply-To: <1362084510-10072-1-git-send-email-christian.babeux@efficios.com>
Signed-off-by: Christian Babeux <christian.babeux@efficios.com>
---
src/bin/lttng/lttng.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/src/bin/lttng/lttng.c b/src/bin/lttng/lttng.c
index 8562144..be673f9 100644
--- a/src/bin/lttng/lttng.c
+++ b/src/bin/lttng/lttng.c
@@ -374,13 +374,12 @@ static int check_sessiond(void)
}
ret = spawn_sessiond(pathname);
- free(alloc_pathname);
if (ret < 0) {
ERR("Problem occurred when starting %s", pathname);
- goto end;
}
- }
+ free(alloc_pathname);
+ }
end:
return ret;
}
--
1.8.1.3
next prev parent reply other threads:[~2013-02-28 20:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1362084510-10072-1-git-send-email-christian.babeux@efficios.com>
2013-02-28 20:48 ` [PATCH lttng-tools] Fix: Memory leaks on error paths in config_read_session_name Christian Babeux
2013-02-28 20:48 ` [PATCH lttng-tools] Fix: Memory leaks on error paths when exporting consumerd libdir in env Christian Babeux
2013-02-28 20:48 ` [PATCH lttng-tools] Fix: Memory leaks on unknown hashtable type error handling Christian Babeux
2013-02-28 20:48 ` [PATCH lttng-tools] Fix: Memory leaks when calling get_cmdline_by_pid Christian Babeux
2013-02-28 20:48 ` [PATCH lttng-tools] Fix: Memory leak when zmalloc fail on kernel channel allocation Christian Babeux
2013-02-28 20:48 ` Christian Babeux [this message]
2013-03-21 17:32 ` [PATCH lttng-tools] Fix: Memory leak on error paths of relay_add_stream David Goulet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='1362084510-10072-7-git-send-email-christian.babeux__32251.3043917299$1362084617$gmane$org@efficios.com' \
--to=christian.babeux@efficios.com \
--cc=dgoulet@efficios.com \
--cc=lttng-dev@lists.lttng.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.