From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cong Wang Subject: Re: [Patch net] bridge: do not expire mdb entry when bridge still uses it Date: Fri, 08 Mar 2013 15:26:21 +0800 Message-ID: <1362727581.3237.4.camel@cr0> References: <1362708423-23932-1-git-send-email-amwang@redhat.com> <20130308023151.GA27155@gondor.apana.org.au> <1362710646.9773.25.camel@cr0> <20130308024726.GA27319@gondor.apana.org.au> <1362715613.9773.29.camel@cr0> <20130308040853.GA27704@gondor.apana.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: Stephen Hemminger , netdev@vger.kernel.org, bridge@lists.linux-foundation.org, "David S. Miller" , Adam Baker To: Herbert Xu Return-path: In-Reply-To: <20130308040853.GA27704@gondor.apana.org.au> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: bridge-bounces@lists.linux-foundation.org Errors-To: bridge-bounces@lists.linux-foundation.org List-Id: netdev.vger.kernel.org On Fri, 2013-03-08 at 12:08 +0800, Herbert Xu wrote: > On Fri, Mar 08, 2013 at 12:06:53PM +0800, Cong Wang wrote: > > > > The mdst may be removed, however the BR_INPUT_SKB_CB_MROUTERS_ONLY(skb) > > is still set, because in br_multicast_ipv4_rcv(): > > But those packets are only meant for routers, which is why we > have the br_multicast_is_router test above. > Hmm, what the user experiences is the multicast traffic between the bridge and some port is broken. Isn't this expected to work by default? Or we can just change the default value of br->multicast_router to 2? Thanks! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <1362727581.3237.4.camel@cr0> From: Cong Wang Date: Fri, 08 Mar 2013 15:26:21 +0800 In-Reply-To: <20130308040853.GA27704@gondor.apana.org.au> References: <1362708423-23932-1-git-send-email-amwang@redhat.com> <20130308023151.GA27155@gondor.apana.org.au> <1362710646.9773.25.camel@cr0> <20130308024726.GA27319@gondor.apana.org.au> <1362715613.9773.29.camel@cr0> <20130308040853.GA27704@gondor.apana.org.au> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Subject: Re: [Bridge] [Patch net] bridge: do not expire mdb entry when bridge still uses it List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Herbert Xu Cc: Stephen Hemminger , netdev@vger.kernel.org, bridge@lists.linux-foundation.org, "David S. Miller" , Adam Baker On Fri, 2013-03-08 at 12:08 +0800, Herbert Xu wrote: > On Fri, Mar 08, 2013 at 12:06:53PM +0800, Cong Wang wrote: > > > > The mdst may be removed, however the BR_INPUT_SKB_CB_MROUTERS_ONLY(skb) > > is still set, because in br_multicast_ipv4_rcv(): > > But those packets are only meant for routers, which is why we > have the br_multicast_is_router test above. > Hmm, what the user experiences is the multicast traffic between the bridge and some port is broken. Isn't this expected to work by default? Or we can just change the default value of br->multicast_router to 2? Thanks!