From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58006) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UEgbk-0003a7-F3 for qemu-devel@nongnu.org; Sun, 10 Mar 2013 09:48:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UEgbg-0001UK-RO for qemu-devel@nongnu.org; Sun, 10 Mar 2013 09:48:12 -0400 Received: from mail-lb0-f172.google.com ([209.85.217.172]:49503) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UEgbg-0001U3-Kv for qemu-devel@nongnu.org; Sun, 10 Mar 2013 09:48:08 -0400 Received: by mail-lb0-f172.google.com with SMTP id n8so2481435lbj.31 for ; Sun, 10 Mar 2013 06:48:07 -0700 (PDT) From: Igor Mitsyanko Date: Sun, 10 Mar 2013 17:47:57 +0400 Message-Id: <1362923278-4080-3-git-send-email-i.mitsyanko@gmail.com> In-Reply-To: <1362923278-4080-1-git-send-email-i.mitsyanko@gmail.com> References: <1362923278-4080-1-git-send-email-i.mitsyanko@gmail.com> Subject: [Qemu-devel] [PATCH 2/3] hw/sd.c: fix migration of dynamically allocated buffer "buf" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, i.mitsyanko@gmail.com, andrew@openedhand.com, michael@walle.cc, paul@codesourcery.com, anthony@codemonkey.ws VMSTATE_BUFFER_UNSAFE should be used for buffers inlined in device state, not for buffers allocated dynamically. Change to VMSTATE_BUFFER_POINTER_UNSAFE macro, which will do migration right. Signed-off-by: Igor Mitsyanko --- hw/sd.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/sd.c b/hw/sd.c index 428bd78..88eaaf8 100644 --- a/hw/sd.c +++ b/hw/sd.c @@ -478,7 +478,7 @@ static const VMStateDescription sd_vmstate = { VMSTATE_UINT64(data_start, SDState), VMSTATE_UINT32(data_offset, SDState), VMSTATE_UINT8_ARRAY(data, SDState, 512), - VMSTATE_BUFFER_UNSAFE(buf, SDState, 1, 512), + VMSTATE_BUFFER_POINTER_UNSAFE(buf, SDState, 1, 512), VMSTATE_BOOL(enable, SDState), VMSTATE_END_OF_LIST() } -- 1.7.5.4