All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <Ian.Campbell@citrix.com>
To: "fantonifabio@tiscali.it" <fantonifabio@tiscali.it>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
	Fabio Fantoni <fabio.fantoni@heliman.it>,
	Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>
Subject: Re: [PATCH] tools/firmware: Fix ovmf build with gcc version different from 4.4
Date: Tue, 12 Mar 2013 15:32:47 +0000	[thread overview]
Message-ID: <1363102367.32410.10.camel@zakaz.uk.xensource.com> (raw)
In-Reply-To: <1361193850-5028-1-git-send-email-fantonifabio@tiscali.it>

On Mon, 2013-02-18 at 13:24 +0000, fantonifabio@tiscali.it wrote:
> From: Fabio Fantoni <fabio.fantoni@heliman.it>
> 
> Signed-off-by: Fabio Fantoni <fabio.fantoni@heliman.it>
> ---
>  tools/firmware/ovmf-makefile |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/firmware/ovmf-makefile b/tools/firmware/ovmf-makefile
> index c3cd466..72fe99d 100644
> --- a/tools/firmware/ovmf-makefile
> +++ b/tools/firmware/ovmf-makefile
> @@ -1,6 +1,8 @@
>  # OVMF building system is not ready yet to run in parallel.
>  # Force it to be serial in order to exploit parallelism for neighbors.
>  
> +GCCVERSION = $(shell gcc --version | grep -om1 '[0-9]\+[.][0-9]\+' | tr -d . | tail -n1)
> +
>  .NOTPARALLEL:
>  MAKEFLAGS  += -j1
>  
> @@ -10,7 +12,7 @@ all: ovmf.bin
>  .PHONY: ovmf.bin
>  ovmf.bin:
>  	OvmfPkg/build.sh -a X64
> -	cp Build/OvmfX64/DEBUG_GCC44/FV/OVMF.fd ovmf.bin
> +	cp Build/OvmfX64/DEBUG_GCC$(GCCVERSION)/FV/OVMF.fd ovmf.bin

Does "cp Build/OvmfX64/DEBUG_GCC??/FV/OVMF.fd ovmf.bin" work instead?
(or perhaps * instead of ??). This avoids needing to parse gcc --version
output, which is likely going to be fragile.

Ian.

      parent reply	other threads:[~2013-03-12 15:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-18 13:24 [PATCH] tools/firmware: Fix ovmf build with gcc version different from 4.4 fantonifabio
2013-02-18 14:17 ` Keir Fraser
2013-03-12 15:32 ` Ian Campbell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1363102367.32410.10.camel@zakaz.uk.xensource.com \
    --to=ian.campbell@citrix.com \
    --cc=Stefano.Stabellini@eu.citrix.com \
    --cc=fabio.fantoni@heliman.it \
    --cc=fantonifabio@tiscali.it \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.