From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Eilon Greenstein" Subject: Re: [PATCH] bnx2x: fix occasional statistics off-by-4GB error Date: Sun, 17 Mar 2013 21:37:54 +0200 Message-ID: <1363549074.4752.3.camel@lb-tlvb-eilong.il.broadcom.com> References: <1363384577-21287-1-git-send-email-zenczykowski@gmail.com> <504C9EFCA2D0054393414C9CB605C37F20BE6A2B@SJEXCHMB06.corp.ad.broadcom.com> <20130317.142425.1713640249735424829.davem@davemloft.net> Reply-To: eilong@broadcom.com Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: dmitry@broadcom.com, zenczykowski@gmail.com, maze@google.com, netdev@vger.kernel.org, yuvalmin@broadcom.com To: "David Miller" Return-path: Received: from mms3.broadcom.com ([216.31.210.19]:4662 "EHLO mms3.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755751Ab3CQTjm (ORCPT ); Sun, 17 Mar 2013 15:39:42 -0400 In-Reply-To: <20130317.142425.1713640249735424829.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: On Sun, 2013-03-17 at 14:24 -0400, David Miller wrote: > From: "Dmitry Kravkov" > Date: Sun, 17 Mar 2013 13:10:37 +0000 > > > Probably this commit resolved the issue: > > > > commit bef05406ac0ea6f468e1e25e9934f3011ea9259b > > Author: Dmitry Kravkov > > Date: Tue Sep 11 04:34:08 2012 +0000 > > > > bnx2x: Avoid sending multiple statistics queries > > > > Can you try it pls? > > These are completely seperate bugs. > > The macro in question does not handle rollover of the lower 32-bits of > the statistic properly at all, and therefore Maciej's patch should be > applied and queud up for -stable. > > Please give it your ACK unless you can find a bug in his change. Both the high value and the low value are read from the chip - so this patch will increment the higher 32 bits twice (well, more than once). Not taking the HW/FW high counter at all is also not acceptable since the reading frequency is not high enough without those. So the original patch is nacked, but we are trying to figure out what is causing the statistics to misbehave and it might be related to sending statistics query twice. Thanks, Eilon