From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH 3/4] xen-netback: remove skb in xen_netbk_alloc_page Date: Mon, 18 Mar 2013 11:37:28 +0000 Message-ID: <1363606648.30193.18.camel@zakaz.uk.xensource.com> References: <1363602955-24790-1-git-send-email-wei.liu2@citrix.com> <1363602955-24790-4-git-send-email-wei.liu2@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: "netdev@vger.kernel.org" , "xen-devel@lists.xen.org" , "konrad.wilk@oracle.com" , "annie.li@oracle.com" To: Wei Liu Return-path: Received: from smtp.eu.citrix.com ([46.33.159.39]:32231 "EHLO SMTP.EU.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750899Ab3CRLhb (ORCPT ); Mon, 18 Mar 2013 07:37:31 -0400 In-Reply-To: <1363602955-24790-4-git-send-email-wei.liu2@citrix.com> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, 2013-03-18 at 10:35 +0000, Wei Liu wrote: > This variable is never used. > > Signed-off-by: Wei Liu Acked-by: Ian Campbell > --- > drivers/net/xen-netback/netback.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c > index da726a3..6e8e51a 100644 > --- a/drivers/net/xen-netback/netback.c > +++ b/drivers/net/xen-netback/netback.c > @@ -948,7 +948,6 @@ static int netbk_count_requests(struct xenvif *vif, > } > > static struct page *xen_netbk_alloc_page(struct xen_netbk *netbk, > - struct sk_buff *skb, > u16 pending_idx) > { > struct page *page; > @@ -982,7 +981,7 @@ static struct gnttab_copy *xen_netbk_get_requests(struct xen_netbk *netbk, > > index = pending_index(netbk->pending_cons++); > pending_idx = netbk->pending_ring[index]; > - page = xen_netbk_alloc_page(netbk, skb, pending_idx); > + page = xen_netbk_alloc_page(netbk, pending_idx); > if (!page) > goto err; > > @@ -1387,7 +1386,7 @@ static unsigned xen_netbk_tx_build_gops(struct xen_netbk *netbk) > } > > /* XXX could copy straight to head */ > - page = xen_netbk_alloc_page(netbk, skb, pending_idx); > + page = xen_netbk_alloc_page(netbk, pending_idx); > if (!page) { > kfree_skb(skb); > netbk_tx_err(vif, &txreq, idx);