All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Tejun Heo <tj@kernel.org>
Cc: Ingo Molnar <mingo@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	linux-kernel@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>,
	Clark Williams <clark@redhat.com>
Subject: Re: [PATCH] scheduler: convert BUG_ON()s in try_to_wake_up_local() to WARN_ON_ONCE()s
Date: Mon, 18 Mar 2013 15:32:20 -0400	[thread overview]
Message-ID: <1363635140.28194.10.camel@gandalf.local.home> (raw)
In-Reply-To: <20130318192234.GD3042@htj.dyndns.org>

On Mon, 2013-03-18 at 12:22 -0700, Tejun Heo wrote:
> try_to_wake_up_local() should only be invoked to wake up another task
> in the same runqueue and BUG_ON()s are used to enforce the rule.
> Missing try_to_wake_up_local() can stall workqueue execution but such
> stalls are likely to be finite either by another work item being
> queued or the one blocked getting unblocked.  There's no reason to
> trigger BUG while holding rq lock crashing the whole system.
> 
> Convert BUG_ON()s in try_to_wake_up_local() to WARN_ON_ONCE()s.
> 
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Cc: Steven Rostedt <rostedt@goodmis.org>

Acked-by: Steven Rostedt <rostedt@goodmis.org>

-- Steve

> ---
>  kernel/sched/core.c |    6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index 7f12624..a2eda4d 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -1498,8 +1498,10 @@ static void try_to_wake_up_local(struct task_struct *p)
>  {
>  	struct rq *rq = task_rq(p);
>  
> -	BUG_ON(rq != this_rq());
> -	BUG_ON(p == current);
> +	if (WARN_ON_ONCE(rq != this_rq()) ||
> +	    WARN_ON_ONCE(p == current))
> +		return;
> +
>  	lockdep_assert_held(&rq->lock);
>  
>  	if (!raw_spin_trylock(&p->pi_lock)) {



  reply	other threads:[~2013-03-18 19:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-18 19:22 Tejun Heo
2013-03-18 19:32 ` Steven Rostedt [this message]
2013-03-19 10:14 ` Peter Zijlstra
2013-03-19 11:29   ` Steven Rostedt
2013-03-21 18:14 ` [tip:sched/urgent] sched: Convert BUG_ON() s " tip-bot for Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1363635140.28194.10.camel@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=clark@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=tj@kernel.org \
    --subject='Re: [PATCH] scheduler: convert BUG_ON()s in try_to_wake_up_local() to WARN_ON_ONCE()s' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.