All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dinh Nguyen <dinguyen@altera.com>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: dwmw2@infradead.org, dedekind1@gmail.com,
	linux-mtd@lists.infradead.org, artem.bityutskiy@linux.intel.com
Subject: Re: [PATCH 4/4] mtd: denali_dt: Remove redundant use of of_match_ptr
Date: Tue, 19 Mar 2013 11:08:47 -0500	[thread overview]
Message-ID: <1363709327.17844.0.camel@linux-builds1> (raw)
In-Reply-To: <1363599674-26933-4-git-send-email-sachin.kamat@linaro.org>

Hi Sachin,

On Mon, 2013-03-18 at 15:11 +0530, Sachin Kamat wrote:
> Since this driver is dt only and denali_nand_dt_ids is always
> compiled in, use of of_match_ptr() macro is not necessary.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
>  drivers/mtd/nand/denali_dt.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/mtd/nand/denali_dt.c b/drivers/mtd/nand/denali_dt.c
> index 067a505..9253024 100644
> --- a/drivers/mtd/nand/denali_dt.c
> +++ b/drivers/mtd/nand/denali_dt.c
> @@ -146,7 +146,7 @@ static struct platform_driver denali_dt_driver = {
>  	.driver		= {
>  		.name	= "denali-nand-dt",
>  		.owner	= THIS_MODULE,
> -		.of_match_table	= of_match_ptr(denali_nand_dt_ids),
> +		.of_match_table	= denali_nand_dt_ids,
>  	},
>  };
>  

Reviewed-by: Dinh Nguyen <dinguyen@altera.com>

for all 4 patches.

Thanks,
Dinh

  reply	other threads:[~2013-03-19 16:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-18  9:41 [PATCH 1/4] mtd: denali_dt: Fix incorrect error check Sachin Kamat
2013-03-18  9:41 ` [PATCH 2/4] mtd: denali_dt: Use module_platform_driver() Sachin Kamat
2013-03-18  9:41 ` [PATCH 3/4] mtd: denali_dt: Change return value to fix smatch warning Sachin Kamat
2013-03-18  9:41 ` [PATCH 4/4] mtd: denali_dt: Remove redundant use of of_match_ptr Sachin Kamat
2013-03-19 16:08   ` Dinh Nguyen [this message]
2013-04-05 12:04 ` [PATCH 1/4] mtd: denali_dt: Fix incorrect error check Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1363709327.17844.0.camel@linux-builds1 \
    --to=dinguyen@altera.com \
    --cc=artem.bityutskiy@linux.intel.com \
    --cc=dedekind1@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=sachin.kamat@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.