From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH 11/12] xen/events: Add the hypervisor
 interface for the FIFO-based event channels
Date: Wed, 20 Mar 2013 14:36:30 +0000
Message-ID: <1363790190.3088.46.camel@zion.uk.xensource.com>
References: <1363727099-25519-1-git-send-email-david.vrabel@citrix.com>
	<1363727099-25519-12-git-send-email-david.vrabel@citrix.com>
	<1363788209.3088.42.camel@zion.uk.xensource.com>
	<5149C552.5010204@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <5149C552.5010204@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: David Vrabel <david.vrabel@citrix.com>
Cc: "Keir (Xen.org)" <keir@xen.org>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>, wei.liu2@citrix.com, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
List-Id: xen-devel@lists.xenproject.org

On Wed, 2013-03-20 at 14:18 +0000, David Vrabel wrote:
> On 20/03/13 14:03, Wei Liu wrote:
> > On Tue, 2013-03-19 at 21:04 +0000, David Vrabel wrote:
> >> From: David Vrabel <david.vrabel@citrix.com>
> >>
> >> Add the hypercall sub-ops and the structures for the shared data used
> >> in the FIFO-based event channel ABI.
> >>
> >> Signed-off-by: David Vrabel <david.vrabel@citrix.com>
> >> ---
> >>  include/xen/interface/event_channel.h |   70 +++++++++++++++++++++++++++++++++
> >>  1 files changed, 70 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/include/xen/interface/event_channel.h b/include/xen/interface/event_channel.h
> >> index f494292..10472f5 100644
> >> --- a/include/xen/interface/event_channel.h
> >> +++ b/include/xen/interface/event_channel.h
> >> @@ -190,6 +190,50 @@ struct evtchn_reset {
> >>  };
> >>  typedef struct evtchn_reset evtchn_reset_t;
> >>  
> > 
> > This typedef slipped into the header and should be removed. No typedef
> > in Linux header.
> 
> This has nothing to do with this series.
> 

IIRC this one was my fault when I upstreamed evtchn_reset. I have a
trivial patch to remove it.

> However, I will make sure I don't add any more typedefs for structures.
> 

Yes please.


Wei.