All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Frank Schäfer" <fschaefer.oss@googlemail.com>
To: mchehab@redhat.com
Cc: hverkuil@xs4all.nl, linux-media@vger.kernel.org,
	"Frank Schäfer" <fschaefer.oss@googlemail.com>
Subject: [RFC PATCH 08/10] bttv: apply mute settings on open
Date: Wed, 20 Mar 2013 20:24:48 +0100	[thread overview]
Message-ID: <1363807490-3906-9-git-send-email-fschaefer.oss@googlemail.com> (raw)
In-Reply-To: <1363807490-3906-1-git-send-email-fschaefer.oss@googlemail.com>

Previously, this has been done implicitly for video device nodes by calling
set_input() (which calls audio_input() and also modified the mute
setting).
Since input and mute setting are now untangled (as much as possible), we need to
apply the mute setting with an explicit call to audio_mute().
Also apply the mute setting when the radio device node gets opened.

Signed-off-by: Frank Schäfer <fschaefer.oss@googlemail.com>
---
 drivers/media/pci/bt8xx/bttv-driver.c |    3 ++-
 1 Datei geändert, 2 Zeilen hinzugefügt(+), 1 Zeile entfernt(-)

diff --git a/drivers/media/pci/bt8xx/bttv-driver.c b/drivers/media/pci/bt8xx/bttv-driver.c
index 55eab61..2fb2168 100644
--- a/drivers/media/pci/bt8xx/bttv-driver.c
+++ b/drivers/media/pci/bt8xx/bttv-driver.c
@@ -3065,7 +3065,7 @@ static int bttv_open(struct file *file)
 			    fh, &btv->lock);
 	set_tvnorm(btv,btv->tvnorm);
 	set_input(btv, btv->input, btv->tvnorm);
-
+	audio_mute(btv, btv->mute);
 
 	/* The V4L2 spec requires one global set of cropping parameters
 	   which only change on request. These are stored in btv->crop[1].
@@ -3230,6 +3230,7 @@ static int radio_open(struct file *file)
 	v4l2_fh_init(&fh->fh, vdev);
 
 	btv->radio_user++;
+	audio_mute(btv, btv->mute);
 
 	v4l2_fh_add(&fh->fh);
 
-- 
1.7.10.4


  parent reply	other threads:[~2013-03-20 19:24 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-20 19:24 [RFC PATCH 00/10] bttv: refactor audio_mux() and fix muting/unmuting Frank Schäfer
2013-03-20 19:24 ` [RFC PATCH 01/10] bttv: audio_mux(): use a local variable "gpio_mute" instead of modifying the function parameter "mute" Frank Schäfer
2013-03-21 10:24   ` Hans Verkuil
2013-03-20 19:24 ` [RFC PATCH 02/10] bttv: audio_mux(): do not change the value of the v4l2 mute control Frank Schäfer
2013-03-21 10:26   ` Hans Verkuil
2013-03-20 19:24 ` [RFC PATCH 03/10] bttv: do not save the audio input in audio_mux() Frank Schäfer
2013-03-21 10:28   ` Hans Verkuil
2013-03-20 19:24 ` [RFC PATCH 04/10] bttv: rename field 'audio' in struct 'bttv' to 'audio_input' Frank Schäfer
2013-03-21 10:28   ` Hans Verkuil
2013-03-20 19:24 ` [RFC PATCH 05/10] bttv: separate GPIO part from function audio_mux() Frank Schäfer
2013-03-21 10:32   ` Hans Verkuil
2013-03-20 19:24 ` [RFC PATCH 06/10] bttv: untangle audio input and mute setting Frank Schäfer
2013-03-21 10:37   ` Hans Verkuil
2013-03-20 19:24 ` [RFC PATCH 07/10] bttv: do not unmute the device before the first open Frank Schäfer
2013-03-21 10:38   ` Hans Verkuil
2013-03-20 19:24 ` Frank Schäfer [this message]
2013-03-21 10:39   ` [RFC PATCH 08/10] bttv: apply mute settings on open Hans Verkuil
2013-03-20 19:24 ` [RFC PATCH 09/10] bttv: fix mute on last close of the video device node Frank Schäfer
2013-03-21 10:56   ` Hans Verkuil
2013-03-21 17:44     ` Frank Schäfer
2013-03-20 19:24 ` [RFC PATCH 10/10] bttv: avoid mute on last close when the radio device node is still open Frank Schäfer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1363807490-3906-9-git-send-email-fschaefer.oss@googlemail.com \
    --to=fschaefer.oss@googlemail.com \
    --cc=hverkuil@xs4all.nl \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.