All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/8] patman: Don't look for tags inside quotes
Date: Wed, 20 Mar 2013 19:42:55 -0700	[thread overview]
Message-ID: <1363833781-14557-3-git-send-email-sjg@chromium.org> (raw)
In-Reply-To: <1363833781-14557-1-git-send-email-sjg@chromium.org>

At present something like:

   Revert "arm: Add cache operations"

will try to use

   Revert "arm

as a tag. Clearly this is wrong, so fix it.

If the revert is intended to be tagged, then the tag can come before
the revert, perhaps. Alternatively the 'Cc' tag can be used in the commit
messages.

Signed-off-by: Simon Glass <sjg@chromium.org>
---
 tools/patman/commit.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/patman/commit.py b/tools/patman/commit.py
index 7144e54..64baf52 100644
--- a/tools/patman/commit.py
+++ b/tools/patman/commit.py
@@ -22,7 +22,7 @@
 import re
 
 # Separates a tag: at the beginning of the subject from the rest of it
-re_subject_tag = re.compile('([^:]*):\s*(.*)')
+re_subject_tag = re.compile('([^:"]*):\s*(.*)')
 
 class Commit:
     """Holds information about a single commit/patch in the series.
-- 
1.8.1.3

  parent reply	other threads:[~2013-03-21  2:42 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-21  2:42 [U-Boot] [PATCH 0/8] Various patman fixes Simon Glass
2013-03-21  2:42 ` [U-Boot] [PATCH 1/8] patman: Fix up checkpatch parsing to deal with 'CHECK' lines Simon Glass
2013-03-21 16:35   ` Doug Anderson
2013-03-26 22:12     ` Simon Glass
2013-03-21  2:42 ` Simon Glass [this message]
2013-03-21 16:50   ` [U-Boot] [PATCH 2/8] patman: Don't look for tags inside quotes Doug Anderson
2013-03-26 22:14     ` Simon Glass
2013-03-21  2:42 ` [U-Boot] [PATCH 3/8] patman: Minor help message/README fixes Simon Glass
2013-03-21 16:52   ` Doug Anderson
2013-03-21  2:42 ` [U-Boot] [PATCH 4/8] patman: Fix the comment in CheckTags to mention multiple tags Simon Glass
2013-03-21 16:53   ` Doug Anderson
2013-03-21  2:42 ` [U-Boot] [PATCH 5/8] patman: Provide option to ignore bad aliases Simon Glass
2013-03-21 17:09   ` Doug Anderson
2013-03-26 22:46     ` Simon Glass
2013-03-21  2:42 ` [U-Boot] [PATCH 6/8] patman: Add -a option to refrain from test-applying the patches Simon Glass
2013-03-21 17:12   ` Doug Anderson
2013-03-21  2:43 ` [U-Boot] [PATCH 7/8] patman: Add Cover-letter-cc tag to Cc cover letter to people Simon Glass
2013-03-21  3:46   ` Doug Anderson
2013-03-21  2:43 ` [U-Boot] [PATCH 8/8] patman: Add Series-process-log tag to sort/uniq change logs Simon Glass
2013-03-21 17:51   ` Doug Anderson
2013-03-26 22:15     ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1363833781-14557-3-git-send-email-sjg@chromium.org \
    --to=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.