All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Lieven <pl@kamp.de>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, pbonzini@redhat.com, Peter Lieven <pl@kamp.de>
Subject: [Qemu-devel] [PATCHv3 4/9] bitops: use vector algorithm to optimize find_next_bit()
Date: Thu, 21 Mar 2013 16:57:32 +0100	[thread overview]
Message-ID: <1363881457-14814-5-git-send-email-pl@kamp.de> (raw)
In-Reply-To: <1363881457-14814-1-git-send-email-pl@kamp.de>

this patch adds the usage of buffer_find_nonzero_offset()
to skip large areas of zeroes.

compared to loop unrolling presented in an earlier
patch this adds another 50% performance benefit for
skipping large areas of zeroes. loop unrolling alone
added close to 100% speedup.

Signed-off-by: Peter Lieven <pl@kamp.de>
---
 util/bitops.c |   22 +++++++++++++++++++---
 1 file changed, 19 insertions(+), 3 deletions(-)

diff --git a/util/bitops.c b/util/bitops.c
index e72237a..8ea79ae 100644
--- a/util/bitops.c
+++ b/util/bitops.c
@@ -42,10 +42,26 @@ unsigned long find_next_bit(const unsigned long *addr, unsigned long size,
         size -= BITS_PER_LONG;
         result += BITS_PER_LONG;
     }
-    while (size & ~(BITS_PER_LONG-1)) {
-        if ((tmp = *(p++))) {
-            goto found_middle;
+    while (size >= BITS_PER_LONG) {
+        if ((tmp = *p)) {
+             goto found_middle;
+        }
+        if (can_use_buffer_find_nonzero_offset(p, size / BITS_PER_BYTE)) {
+            size_t tmp2 =
+                buffer_find_nonzero_offset(p, size / BITS_PER_BYTE);
+            result += tmp2 * BITS_PER_BYTE;
+            size -= tmp2 * BITS_PER_BYTE;
+            p += tmp2 / sizeof(unsigned long);
+            if (!size) {
+                return result;
+            }
+            if (tmp2) {
+                if ((tmp = *p)) {
+                    goto found_middle;
+                }
+            }
         }
+        p++;
         result += BITS_PER_LONG;
         size -= BITS_PER_LONG;
     }
-- 
1.7.9.5

  parent reply	other threads:[~2013-03-21 15:58 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-21 15:57 [Qemu-devel] [PATCHv3 0/9] buffer_is_zero / migration optimizations Peter Lieven
2013-03-21 15:57 ` [Qemu-devel] [PATCHv3 1/9] move vector definitions to qemu-common.h Peter Lieven
2013-03-21 17:29   ` Eric Blake
2013-03-21 15:57 ` [Qemu-devel] [PATCHv3 2/9] cutils: add a function to find non-zero content in a buffer Peter Lieven
2013-03-21 18:12   ` Eric Blake
2013-03-21 19:11     ` Peter Lieven
2013-03-21 15:57 ` [Qemu-devel] [PATCHv3 3/9] buffer_is_zero: use vector optimizations if possible Peter Lieven
2013-03-21 18:16   ` Eric Blake
2013-03-21 15:57 ` Peter Lieven [this message]
2013-03-21 19:18   ` [Qemu-devel] [PATCHv3 4/9] bitops: use vector algorithm to optimize find_next_bit() Eric Blake
2013-03-21 15:57 ` [Qemu-devel] [PATCHv3 5/9] migration: search for zero instead of dup pages Peter Lieven
2013-03-21 19:24   ` Eric Blake
2013-03-21 15:57 ` [Qemu-devel] [PATCHv3 6/9] migration: add an indicator for bulk state of ram migration Peter Lieven
2013-03-21 19:27   ` Eric Blake
2013-03-21 15:57 ` [Qemu-devel] [PATCHv3 7/9] migration: do not sent zero pages in bulk stage Peter Lieven
2013-03-21 19:26   ` Eric Blake
2013-03-21 19:44     ` Peter Lieven
2013-03-21 15:57 ` [Qemu-devel] [PATCHv3 8/9] migration: do not search dirty " Peter Lieven
2013-03-21 19:27   ` Eric Blake
2013-03-21 19:57     ` Peter Lieven
2013-03-21 15:57 ` [Qemu-devel] [PATCHv3 9/9] migration: use XBZRLE only after " Peter Lieven
2013-03-21 19:31   ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1363881457-14814-5-git-send-email-pl@kamp.de \
    --to=pl@kamp.de \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.