All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Anthony Liguori <aliguori@us.ibm.com>,
	Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [PATCH 1/7] net: use socket_set_nodelay() for -netdev socket
Date: Mon, 25 Mar 2013 13:26:07 +0100	[thread overview]
Message-ID: <1364214373-2444-2-git-send-email-stefanha@redhat.com> (raw)
In-Reply-To: <1364214373-2444-1-git-send-email-stefanha@redhat.com>

Reduce -netdev socket latency by disabling the Nagle algorithm on
SOCK_STREAM sockets in net/socket.c.  Since we are tunelling Ethernet
over TCP we shouldn't artificially delay outgoing packets, let the guest
decide packet scheduling.

I already get sub-millisecond -netdev socket ping times on localhost, so
there was no measurable difference in my testing.  This won't hurt
though and may improve remote socket performance.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Benoit Canet <benoit@irqsave.net>
Reviewed-by: Daniel P. Berrange <berrange@redhat.com>
---
 net/socket.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/net/socket.c b/net/socket.c
index d8b35a2..b0c83e0 100644
--- a/net/socket.c
+++ b/net/socket.c
@@ -438,6 +438,9 @@ static NetSocketState *net_socket_fd_init_stream(NetClientState *peer,
     s->fd = fd;
     s->listen_fd = -1;
 
+    /* Disable Nagle algorithm on TCP sockets to reduce latency */
+    socket_set_nodelay(fd);
+
     if (is_connected) {
         net_socket_connect(s);
     } else {
-- 
1.8.1.4

  reply	other threads:[~2013-03-25 12:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-25 12:26 [Qemu-devel] [PULL 0/7] Net patches Stefan Hajnoczi
2013-03-25 12:26 ` Stefan Hajnoczi [this message]
2013-03-25 12:26 ` [Qemu-devel] [PATCH 2/7] Checksum-related utility functions Stefan Hajnoczi
2013-03-25 12:26 ` [Qemu-devel] [PATCH 3/7] net: iovec checksum calculator Stefan Hajnoczi
2013-03-25 12:26 ` [Qemu-devel] [PATCH 4/7] Common definitions for VMWARE devices Stefan Hajnoczi
2013-03-25 12:26 ` [Qemu-devel] [PATCH 5/7] Packet abstraction for VMWARE network devices Stefan Hajnoczi
2013-03-25 12:26 ` [Qemu-devel] [PATCH 6/7] VMXNET3 device implementation Stefan Hajnoczi
2013-03-25 12:26 ` [Qemu-devel] [PATCH 7/7] net: increase buffer size to accommodate Jumbo frame pkts Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1364214373-2444-2-git-send-email-stefanha@redhat.com \
    --to=stefanha@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.