From: Vikas Sajjan <vikas.sajjan@linaro.org>
To: dri-devel@lists.freedesktop.org
Cc: linux-media@vger.kernel.org, kgene.kim@samsung.com,
inki.dae@samsung.com, patches@linaro.org,
linaro-kernel@lists.linaro.org, jy0922.shim@samsung.com,
linux-samsung-soc@vger.kernel.org, thomas.abraham@linaro.org
Subject: [PATCH v4] drm/exynos: prepare FIMD clocks
Date: Mon, 8 Apr 2013 16:37:45 +0530 [thread overview]
Message-ID: <1365419265-21238-1-git-send-email-vikas.sajjan@linaro.org> (raw)
While migrating to common clock framework (CCF), I found that the FIMD clocks
were pulled down by the CCF.
If CCF finds any clock(s) which has NOT been claimed by any of the
drivers, then such clock(s) are PULLed low by CCF.
Calling clk_prepare() for FIMD clocks fixes the issue.
This patch also replaces clk_disable() with clk_unprepare() during exit, since
clk_prepare() is called in fimd_probe().
Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org>
---
Changes since v3:
- added clk_prepare() in fimd_probe() and clk_unprepare() in fimd_remove()
as suggested by Viresh Kumar <viresh.kumar@linaro.org>
Changes since v2:
- moved clk_prepare_enable() and clk_disable_unprepare() from
fimd_probe() to fimd_clock() as suggested by Inki Dae <inki.dae@samsung.com>
Changes since v1:
- added error checking for clk_prepare_enable() and also replaced
clk_disable() with clk_disable_unprepare() during exit.
---
drivers/gpu/drm/exynos/exynos_drm_fimd.c | 14 ++++++++++++--
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
index 9537761..aa22370 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
@@ -934,6 +934,16 @@ static int fimd_probe(struct platform_device *pdev)
return ret;
}
+ ret = clk_prepare(ctx->bus_clk);
+ if (ret < 0)
+ return ret;
+
+ ret = clk_prepare(ctx->lcd_clk);
+ if (ret < 0) {
+ clk_unprepare(ctx->bus_clk);
+ return ret;
+ }
+
ctx->vidcon0 = pdata->vidcon0;
ctx->vidcon1 = pdata->vidcon1;
ctx->default_win = pdata->default_win;
@@ -981,8 +991,8 @@ static int fimd_remove(struct platform_device *pdev)
if (ctx->suspended)
goto out;
- clk_disable(ctx->lcd_clk);
- clk_disable(ctx->bus_clk);
+ clk_unprepare(ctx->lcd_clk);
+ clk_unprepare(ctx->bus_clk);
pm_runtime_set_suspended(dev);
pm_runtime_put_sync(dev);
--
1.7.9.5
next reply other threads:[~2013-04-08 11:07 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-08 11:07 Vikas Sajjan [this message]
2013-04-08 11:11 ` [PATCH v4] drm/exynos: prepare FIMD clocks Viresh Kumar
2013-04-19 8:55 ` Vikas Sajjan
2013-04-20 15:26 ` Inki Dae
2013-04-21 7:24 ` Vikas Sajjan
2013-04-21 7:53 ` Viresh Kumar
2013-04-21 10:35 ` Tomasz Figa
2013-04-21 14:05 ` Inki Dae
2013-04-21 14:15 ` Tomasz Figa
2013-04-21 10:26 ` Tomasz Figa
2013-04-21 13:36 ` Inki Dae
2013-04-21 14:43 ` Tomasz Figa
2013-04-22 5:11 ` Inki Dae
2013-04-22 9:52 ` Tomasz Figa
2013-04-22 10:03 ` Inki Dae
2013-04-22 10:17 ` Sylwester Nawrocki
2013-04-22 10:20 ` Inki Dae
2013-04-22 10:37 ` Tomasz Figa
2013-04-22 11:42 ` Rafael J. Wysocki
2013-04-22 12:04 ` Inki Dae
2013-04-23 11:51 ` myungjoo.ham
2013-04-23 12:09 ` Inki Dae
2013-04-22 11:52 ` Inki Dae
2013-04-22 5:14 ` Viresh Kumar
2013-04-22 9:56 ` Tomasz Figa
2013-04-22 10:05 ` Sylwester Nawrocki
2013-04-22 12:30 ` Tomasz Figa
2013-04-22 10:26 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1365419265-21238-1-git-send-email-vikas.sajjan@linaro.org \
--to=vikas.sajjan@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=inki.dae@samsung.com \
--cc=jy0922.shim@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=patches@linaro.org \
--cc=thomas.abraham@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.