From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH] allow xendomains to work for xl list -l Date: Wed, 10 Apr 2013 14:00:51 +0100 Message-ID: <1365598851.27868.44.camel@zakaz.uk.xensource.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: M A Young Cc: Stefano Stabellini , Ian Jackson , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On Tue, 2013-04-09 at 21:05 +0100, M A Young wrote: > From xen 4.2 onwards xl list -l gives a JSON format output containing no > spaces or line feeds, but the xendomains script expects the older format > (of xl in xen 4.1 and xm) of one key-value pair per line. Hrm, I'm not sure this change was intentional and I don't recall a patch which did this on purpose. Ideally xl list would remain somewhat human readable even if it is also machine readable. I wonder if this is yajl v1 vs v2 specific? For v1 libxl_yajl_gen_alloc creates a yajl_gen_config with beautify = 1 and passes it to yajl_gen_alloc. For v2 however yajl_gen_alloc doesn't take such an option. It looks like we are instead supposed to call yajl_gen_config with yajl_gen_beautify. We probably also want to set yajl_gen_indent_string to " " (although that might be the default from my reading). I don't have a yajl2 test system handy -- could you try that though? [...] > and accepts the "Xen saved > domain" as a valid header for a saved xen image if xl is being used. This bit sounds independently useful too. ISTR someone else sending a similar patch but it fell through the cracks for some reason which I don't remember and I can't find it now. Ian.