From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH] allow xendomains to work for xl list -l Date: Fri, 12 Apr 2013 12:41:58 +0100 Message-ID: <1365766918.15783.25.camel@zakaz.uk.xensource.com> References: <1365598851.27868.44.camel@zakaz.uk.xensource.com> <1365667034.27868.121.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: M A Young Cc: Stefano Stabellini , Ian Jackson , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On Fri, 2013-04-12 at 00:02 +0100, M A Young wrote: > On Thu, 11 Apr 2013, Ian Campbell wrote: > > > On Thu, 2013-04-11 at 00:15 +0100, M A Young wrote: > >> Yes, setting yajl_gen_beautify (as in the attached patch) gets the > >> xendomains script working again. I didn't try setting the spaces though > >> that does indeed seem to be the default. > > > > Cool. I think you need to check for errors after > > g = yajl_gen_alloc(allocFuncs); > > though. > > This version of the patch checks g isn't NULL before trying to set > yajl_gen_beautify . I decided not to test whether yajl_gen_beautify is set > successfully since unbeautified output is probably better than nothing. Agreed. Acked + applied. Your attachment had DOS line endings for some reason... Ian.