From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754480Ab3DREk4 (ORCPT ); Thu, 18 Apr 2013 00:40:56 -0400 Received: from perches-mx.perches.com ([206.117.179.246]:42048 "EHLO labridge.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752618Ab3DREkz (ORCPT ); Thu, 18 Apr 2013 00:40:55 -0400 Message-ID: <1366260053.28609.66.camel@joe-AO722> Subject: Re: [PATCH 1/4] mfd: Kontron PLD mfd driver From: Joe Perches To: Guenter Roeck Cc: Thomas Gleixner , Kevin Strasser , linux-kernel@vger.kernel.org, Michael Brunner , Samuel Ortiz , Wolfram Sang , Ben Dooks , linux-i2c@vger.kernel.org, Grant Likely , Linus Walleij , Wim Van Sebroeck , linux-watchdog@vger.kernel.org, Darren Hart , Michael Brunner , Greg Kroah-Hartman Date: Wed, 17 Apr 2013 21:40:53 -0700 In-Reply-To: <20130418041940.GB7535@roeck-us.net> References: <1365441321-21952-1-git-send-email-kevin.strasser@linux.intel.com> <20130418041940.GB7535@roeck-us.net> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.6.2-0ubuntu0.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2013-04-17 at 21:19 -0700, Guenter Roeck wrote: > On Sat, Apr 13, 2013 at 10:38:07PM +0200, Thomas Gleixner wrote: > > > + return kempld_read8(pld, index) | kempld_read8(pld, index+1) << 8; > > index + 1) > > Please > Wondering .... why does checkpatch not report those ? because checkpatch doesn't care about spacing around arithmetic as long as it's consistent. Documentation/CodingStyle doesn't say anything about it either. Look around checkpatch line 2654 } elsif ($op eq '<<' or $op eq '>>' or $op eq '&' or $op eq '^' or $op eq '|' or $op eq '+' or $op eq '-' or $op eq '*' or $op eq '/' or $op eq '%') { if ($ctx =~ /Wx[^WCE]|[^WCE]xW/) { ERROR("SPACING", "need consistent spacing around '$op' $at\n" . $hereptr); } From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH 1/4] mfd: Kontron PLD mfd driver Date: Wed, 17 Apr 2013 21:40:53 -0700 Message-ID: <1366260053.28609.66.camel@joe-AO722> References: <1365441321-21952-1-git-send-email-kevin.strasser@linux.intel.com> <20130418041940.GB7535@roeck-us.net> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20130418041940.GB7535-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Guenter Roeck Cc: Thomas Gleixner , Kevin Strasser , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Michael Brunner , Samuel Ortiz , Wolfram Sang , Ben Dooks , linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Grant Likely , Linus Walleij , Wim Van Sebroeck , linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Darren Hart , Michael Brunner , Greg Kroah-Hartman List-Id: linux-i2c@vger.kernel.org On Wed, 2013-04-17 at 21:19 -0700, Guenter Roeck wrote: > On Sat, Apr 13, 2013 at 10:38:07PM +0200, Thomas Gleixner wrote: > > > + return kempld_read8(pld, index) | kempld_read8(pld, index+1) << 8; > > index + 1) > > Please > Wondering .... why does checkpatch not report those ? because checkpatch doesn't care about spacing around arithmetic as long as it's consistent. Documentation/CodingStyle doesn't say anything about it either. Look around checkpatch line 2654 } elsif ($op eq '<<' or $op eq '>>' or $op eq '&' or $op eq '^' or $op eq '|' or $op eq '+' or $op eq '-' or $op eq '*' or $op eq '/' or $op eq '%') { if ($ctx =~ /Wx[^WCE]|[^WCE]xW/) { ERROR("SPACING", "need consistent spacing around '$op' $at\n" . $hereptr); }