All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steve Dickson <SteveD@redhat.com>
To: Trond Myklebust <Trond.Myklebust@netapp.com>,
	"J. Bruce Fields" <bfields@redhat.com>,
	"David P. Quigley" <dpquigl@tycho.nsa.gov>
Cc: Linux NFS list <linux-nfs@vger.kernel.org>,
	Linux FS devel list <linux-fsdevel@vger.kernel.org>,
	Linux Security List <linux-security-module@vger.kernel.org>,
	SELinux List <selinux@tycho.nsa.gov>
Subject: [PATCH 14/17] NFS: Extend NFS xattr handlers to accept the security namespace
Date: Thu,  2 May 2013 13:19:08 -0400	[thread overview]
Message-ID: <1367515151-31015-15-git-send-email-SteveD@redhat.com> (raw)
In-Reply-To: <1367515151-31015-1-git-send-email-SteveD@redhat.com>

From: David Quigley <dpquigl@davequigley.com>

The existing NFSv4 xattr handlers do not accept xattr calls to the security
namespace. This patch extends these handlers to accept xattrs from the security
namespace in addition to the default NFSv4 ACL namespace.

Signed-off-by: Matthew N. Dodd <Matthew.Dodd@sparta.com>
Signed-off-by: Miguel Rodel Felipe <Rodel_FM@dsi.a-star.edu.sg>
Signed-off-by: Phua Eu Gene <PHUA_Eu_Gene@dsi.a-star.edu.sg>
Signed-off-by: Khin Mi Mi Aung <Mi_Mi_AUNG@dsi.a-star.edu.sg>
---
 fs/nfs/nfs4proc.c   | 50 ++++++++++++++++++++++++++++++++++++++++++++++++++
 security/security.c |  1 +
 2 files changed, 51 insertions(+)

diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
index 0e5b319..7b65c99 100644
--- a/fs/nfs/nfs4proc.c
+++ b/fs/nfs/nfs4proc.c
@@ -5518,6 +5518,53 @@ static size_t nfs4_xattr_list_nfs4_acl(struct dentry *dentry, char *list,
 	return len;
 }
 
+#ifdef CONFIG_NFS_V4_SECURITY_LABEL
+static inline int nfs4_server_supports_labels(struct nfs_server *server)
+{
+	return server->caps & NFS_CAP_SECURITY_LABEL;
+}
+
+static int nfs4_xattr_set_nfs4_label(struct dentry *dentry, const char *key,
+				   const void *buf, size_t buflen,
+				   int flags, int type)
+{
+	if (security_ismaclabel(key))
+		return nfs4_set_security_label(dentry, buf, buflen);
+
+	return -EOPNOTSUPP;
+}
+
+static int nfs4_xattr_get_nfs4_label(struct dentry *dentry, const char *key,
+				   void *buf, size_t buflen, int type)
+{
+	if (security_ismaclabel(key))
+		return nfs4_get_security_label(dentry->d_inode, buf, buflen);
+	return -EOPNOTSUPP;
+}
+
+static size_t nfs4_xattr_list_nfs4_label(struct dentry *dentry, char *list,
+				       size_t list_len, const char *name,
+				       size_t name_len, int type)
+{
+	size_t len = 0;
+
+	if (nfs_server_capable(dentry->d_inode, NFS_CAP_SECURITY_LABEL)) {
+		len = security_inode_listsecurity(dentry->d_inode, NULL, 0);
+		if (list && len <= list_len)
+			security_inode_listsecurity(dentry->d_inode, list, len);
+	}
+	return len;
+}
+
+static const struct xattr_handler nfs4_xattr_nfs4_label_handler = {
+	.prefix = XATTR_SECURITY_PREFIX,
+	.list	= nfs4_xattr_list_nfs4_label,
+	.get	= nfs4_xattr_get_nfs4_label,
+	.set	= nfs4_xattr_set_nfs4_label,
+};
+#endif
+
+
 /*
  * nfs_fhget will use either the mounted_on_fileid or the fileid
  */
@@ -7270,6 +7317,9 @@ static const struct xattr_handler nfs4_xattr_nfs4_acl_handler = {
 
 const struct xattr_handler *nfs4_xattr_handlers[] = {
 	&nfs4_xattr_nfs4_acl_handler,
+#ifdef CONFIG_NFS_V4_SECURITY_LABEL
+	&nfs4_xattr_nfs4_label_handler,
+#endif
 	NULL
 };
 
diff --git a/security/security.c b/security/security.c
index df8ade2..758af6b 100644
--- a/security/security.c
+++ b/security/security.c
@@ -660,6 +660,7 @@ int security_inode_listsecurity(struct inode *inode, char *buffer, size_t buffer
 		return 0;
 	return security_ops->inode_listsecurity(inode, buffer, buffer_size);
 }
+EXPORT_SYMBOL(security_inode_listsecurity);
 
 void security_inode_getsecid(const struct inode *inode, u32 *secid)
 {
-- 
1.8.1.4


  parent reply	other threads:[~2013-05-02 17:19 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-02 17:18 [PATCH 00/17] lnfs: linux-3.9 release Steve Dickson
2013-05-02 17:18 ` [PATCH 01/17] NFSv4.2: Added v4.2 error codes Steve Dickson
2013-05-02 17:18 ` [PATCH 02/17] NFSv4.2: Added NFS v4.2 support to the NFS client Steve Dickson
     [not found] ` <1367515151-31015-1-git-send-email-SteveD-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-05-02 17:18   ` [PATCH 03/17] NFSDv4.2: Added NFS v4.2 support to the NFS server Steve Dickson
2013-05-02 17:18     ` Steve Dickson
2013-05-02 17:18 ` [PATCH 04/17] Security: Add hook to calculate context based on a negative dentry Steve Dickson
2013-05-02 23:36   ` James Morris
2013-05-02 23:36     ` James Morris
2013-05-02 17:18 ` [PATCH 05/17] Security: Add Hook to test if the particular xattr is part of a MAC model Steve Dickson
2013-05-02 23:36   ` James Morris
2013-05-02 23:36     ` James Morris
2013-05-02 17:19 ` [PATCH 06/17] LSM: Add flags field to security_sb_set_mnt_opts for in kernel mount data Steve Dickson
2013-05-02 23:37   ` James Morris
2013-05-02 23:37     ` James Morris
2013-05-02 17:19 ` [PATCH 07/17] SELinux: Add new labeling type native labels Steve Dickson
     [not found]   ` <1367515151-31015-8-git-send-email-SteveD-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-05-02 23:37     ` James Morris
2013-05-02 23:37       ` James Morris
2013-05-02 23:37       ` James Morris
2013-05-02 17:19 ` [PATCH 08/17] NFSv4: Add label recommended attribute and NFSv4 flags Steve Dickson
2013-05-02 17:19 ` [PATCH 09/17] NFSv4: Introduce new label structure Steve Dickson
2013-05-02 17:19 ` [PATCH 10/17] NFSv4: Extend fattr bitmaps to support all 3 words Steve Dickson
2013-05-02 17:19 ` [PATCH 11/17] NFS:Add labels to client function prototypes Steve Dickson
2013-05-02 17:19 ` [PATCH 12/17] NFS: Add label lifecycle management Steve Dickson
2013-05-02 17:19 ` [PATCH 13/17] NFS: Client implementation of Labeled-NFS Steve Dickson
2013-05-04 19:26   ` J. Bruce Fields
2013-05-06  8:17     ` James Morris
2013-05-06  8:17       ` James Morris
2013-05-02 17:19 ` Steve Dickson [this message]
2013-05-02 23:37   ` [PATCH 14/17] NFS: Extend NFS xattr handlers to accept the security namespace James Morris
2013-05-02 23:37     ` James Morris
2013-05-02 17:19 ` [PATCH 15/17] Kconfig: Add Kconfig entry for Labeled NFS V4 client Steve Dickson
2013-05-02 17:19 ` [PATCH 16/17] NFSD: Server implementation of MAC Labeling Steve Dickson
     [not found]   ` <1367515151-31015-17-git-send-email-SteveD-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-05-09  1:50     ` J. Bruce Fields
2013-05-09  1:50       ` J. Bruce Fields
     [not found]       ` <20130509015033.GI23747-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2013-05-10  1:01         ` J. Bruce Fields
2013-05-10  1:01           ` J. Bruce Fields
2013-05-11 15:19       ` Steve Dickson
2013-05-11 18:33         ` J. Bruce Fields
2013-05-11 21:44       ` Steve Dickson
     [not found]         ` <518EBBD4.7010306-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2013-05-11 22:57           ` J. Bruce Fields
2013-05-11 22:57             ` J. Bruce Fields
2013-05-02 17:19 ` [PATCH 17/17] Kconfig: Add Kconfig entry for Labeled NFS V4 server Steve Dickson
2013-05-04  4:17 ` [PATCH 00/17] lnfs: linux-3.9 release Ric Wheeler
2013-05-06  8:19   ` James Morris
2013-05-06  8:19     ` James Morris
     [not found]     ` <alpine.LRH.2.02.1305061817290.28613-CK9fWmtY32x9JUWOpEiw7w@public.gmane.org>
2013-05-06  8:50       ` Ric Wheeler
2013-05-06  8:50         ` Ric Wheeler
     [not found]   ` <51848BE0.2080901-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-05-06 15:53     ` James Bottomley
2013-05-06 15:53       ` James Bottomley
2013-05-06 19:56       ` Ric Wheeler
2013-05-06 20:25         ` James Bottomley
2013-05-12 21:56           ` David Quigley
2013-05-12 21:56             ` David Quigley
2013-05-12 21:56             ` David Quigley
2013-05-13 13:00             ` Vu, Joseph
2013-05-13 13:00               ` Vu, Joseph
2013-05-13 13:00               ` Vu, Joseph
  -- strict thread matches above, loose matches on Subject: below --
2013-04-29 12:57 [PATCH 00/17] lnfs: 3.9-rc8 release (take 2) Steve Dickson
2013-04-29 12:57 ` [PATCH 14/17] NFS: Extend NFS xattr handlers to accept the security namespace Steve Dickson
2013-04-24 20:17 [PATCH 00/17] lnfs: 3.9-rc8 release Steve Dickson
2013-04-24 20:18 ` [PATCH 14/17] NFS: Extend NFS xattr handlers to accept the security namespace Steve Dickson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1367515151-31015-15-git-send-email-SteveD@redhat.com \
    --to=steved@redhat.com \
    --cc=Trond.Myklebust@netapp.com \
    --cc=bfields@redhat.com \
    --cc=dpquigl@tycho.nsa.gov \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=selinux@tycho.nsa.gov \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.