All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mikel Astiz <mikel.astiz.oss@gmail.com>
To: linux-bluetooth@vger.kernel.org
Cc: Mikel Astiz <mikel.astiz@bmw-carit.de>
Subject: [RFC BlueZ v0 11/13] dbus: Deprecate old profile-connecting API
Date: Mon,  6 May 2013 10:43:28 +0200	[thread overview]
Message-ID: <1367829810-8262-12-git-send-email-mikel.astiz.oss@gmail.com> (raw)
In-Reply-To: <1367829810-8262-1-git-send-email-mikel.astiz.oss@gmail.com>

From: Mikel Astiz <mikel.astiz@bmw-carit.de>

The new org.bluez.Service1 interface deprecates the old UUID-specific
connect/disconnect methods in org.bluez.Device1.
---
 doc/device-api.txt | 4 ++--
 src/device.c       | 6 ++++--
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/doc/device-api.txt b/doc/device-api.txt
index 187f2bf..1e294ad 100644
--- a/doc/device-api.txt
+++ b/doc/device-api.txt
@@ -40,7 +40,7 @@ Methods		void Connect()
 
 			Possible errors: org.bluez.Error.NotConnected
 
-		void ConnectProfile(string uuid)
+		void ConnectProfile(string uuid) [Deprecated]
 
 			This method connects a specific profile of this
 			device. The UUID provided is the remote service
@@ -50,7 +50,7 @@ Methods		void Connect()
 					 org.bluez.Error.AlreadyConnected
 					 org.bluez.Error.ConnectFailed
 
-		void DisconnectProfile(string uuid)
+		void DisconnectProfile(string uuid) [Deprecated]
 
 			This method disconnects a specific profile of
 			this device. The profile needs to be registered
diff --git a/src/device.c b/src/device.c
index 41e0e15..720a476 100644
--- a/src/device.c
+++ b/src/device.c
@@ -1667,9 +1667,11 @@ static DBusMessage *cancel_pairing(DBusConnection *conn, DBusMessage *msg,
 static const GDBusMethodTable device_methods[] = {
 	{ GDBUS_ASYNC_METHOD("Disconnect", NULL, NULL, disconnect) },
 	{ GDBUS_ASYNC_METHOD("Connect", NULL, NULL, dev_connect) },
-	{ GDBUS_ASYNC_METHOD("ConnectProfile", GDBUS_ARGS({ "UUID", "s" }),
+	{ GDBUS_DEPRECATED_ASYNC_METHOD("ConnectProfile",
+						GDBUS_ARGS({ "UUID", "s" }),
 						NULL, connect_profile) },
-	{ GDBUS_ASYNC_METHOD("DisconnectProfile", GDBUS_ARGS({ "UUID", "s" }),
+	{ GDBUS_DEPRECATED_ASYNC_METHOD("DisconnectProfile",
+						GDBUS_ARGS({ "UUID", "s" }),
 						NULL, disconnect_profile) },
 	{ GDBUS_ASYNC_METHOD("Pair", NULL, NULL, pair_device) },
 	{ GDBUS_METHOD("CancelPairing", NULL, NULL, cancel_pairing) },
-- 
1.8.1.4


  parent reply	other threads:[~2013-05-06  8:43 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-06  8:43 [RFC BlueZ v0 00/13] Add experimental org.bluez.Service1 Mikel Astiz
2013-05-06  8:43 ` [RFC BlueZ v0 01/13] test: Remove obsolete test script Mikel Astiz
2013-05-06  8:43 ` [RFC BlueZ v0 02/13] test: Add UUID alias table to bluezutils.py Mikel Astiz
2013-05-06  8:43 ` [RFC BlueZ v0 03/13] test: Support human-friendly UUIDs in test-device Mikel Astiz
2013-05-06  8:43 ` [RFC BlueZ v0 04/13] test: Show human-friendly UUIDs in list-devices Mikel Astiz
2013-05-06  8:43 ` [RFC BlueZ v0 05/13] dbus: Add new org.bluez.Service1 Mikel Astiz
2013-05-06  8:43 ` [RFC BlueZ v0 06/13] dbus: Add Device property to org.bluez.Service1 Mikel Astiz
2013-05-06  8:43 ` [RFC BlueZ v0 07/13] dbus: Add UUID " Mikel Astiz
2013-05-06  8:43 ` [RFC BlueZ v0 08/13] dbus: Add state " Mikel Astiz
2013-05-06 10:00   ` Luiz Augusto von Dentz
2013-05-07  7:49     ` Mikel Astiz
2013-05-06  8:43 ` [RFC BlueZ v0 09/13] dbus: Add Connect/Disconnect " Mikel Astiz
2013-05-06  8:43 ` [RFC BlueZ v0 10/13] doc: Add API documentation for org.bluez.Service1 Mikel Astiz
2013-05-15 16:38   ` Scott James Remnant
2013-05-16  6:22     ` Mikel Astiz
2013-05-16 17:10       ` Scott James Remnant
2013-05-17  9:20         ` Mikel Astiz
2013-05-06  8:43 ` Mikel Astiz [this message]
2013-05-06  8:43 ` [RFC BlueZ v0 12/13] test: Add test-service script Mikel Astiz
2013-05-06  8:43 ` [RFC BlueZ v0 13/13] test: Add --uuid to test-service Mikel Astiz
2013-05-06  9:19 ` [RFC BlueZ v0 00/13] Add experimental org.bluez.Service1 Luiz Augusto von Dentz
2013-05-15  8:56   ` Mikel Astiz
2013-05-28  9:45     ` Mikel Astiz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1367829810-8262-12-git-send-email-mikel.astiz.oss@gmail.com \
    --to=mikel.astiz.oss@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=mikel.astiz@bmw-carit.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.