All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eryu Guan <eguan@redhat.com>
To: xfs@oss.sgi.com
Cc: Eryu Guan <eguan@redhat.com>
Subject: [PATCH v3] xfstests generic 312: test fallocate(2) ENOSPC when file size is greater than 4G
Date: Mon,  6 May 2013 17:42:35 +0800	[thread overview]
Message-ID: <1367833355-14473-1-git-send-email-eguan@redhat.com> (raw)

ENOSPC in fallocate(2) could corrupt ext4 when file size > 4G

Regression test for commit
29ae07b ext4: Fix overflow caused by missing cast in ext4_fallocate()

Signed-off-by: Eryu Guan <eguan@redhat.com>
---
v3: rebase on top of master
v2: Check for $SCRATCH_DEV size, _notrun if it's smaller than 5G

 tests/generic/312     | 72 +++++++++++++++++++++++++++++++++++++++++++++++++++
 tests/generic/312.out |  2 ++
 tests/generic/group   |  1 +
 3 files changed, 75 insertions(+)
 create mode 100644 tests/generic/312
 create mode 100644 tests/generic/312.out

diff --git a/tests/generic/312 b/tests/generic/312
new file mode 100644
index 0000000..eaec43c
--- /dev/null
+++ b/tests/generic/312
@@ -0,0 +1,72 @@
+#! /bin/bash
+# FS QA Test No. 312
+#
+# ENOSPC in fallocate(2) could corrupt ext4 when file size > 4G
+#
+# Regression test for commit
+# 29ae07b ext4: Fix overflow caused by missing cast in ext4_fallocate()
+#
+#-----------------------------------------------------------------------
+# Copyright (c) 2013 Red Hat, Inc.  All Rights Reserved.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it would be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write the Free Software Foundation,
+# Inc.,  51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
+#-----------------------------------------------------------------------
+#
+
+seq=`basename $0`
+seqres=$RESULT_DIR/$seq
+echo "QA output created by $seq"
+
+here=`pwd`
+tmp=/tmp/$$
+status=1	# failure is the default!
+trap "_cleanup; exit \$status" 0 1 2 3 15
+
+_cleanup()
+{
+    cd /
+    rm -f $tmp.*
+}
+
+# get standard environment, filters and checks
+. ./common/rc
+. ./common/filter
+
+# real QA test starts here
+_supported_fs generic
+_supported_os Linux
+_require_xfs_io_falloc
+_require_scratch
+
+# 5G in byte
+fssize=$((2**30 * 5))
+required_blocks=$(($fssize / 1024))
+dev_blocks=$(grep $(basename $(readlink -f $SCRATCH_DEV)) /proc/partitions | $AWK_PROG '{print $3}')
+if [ $required_blocks -gt $dev_blocks ];then
+	_notrun "this test requires \$SCRATCH_DEV has ${fssize}B space"
+fi
+
+rm -f $seqres.full
+_scratch_mkfs_sized $fssize >>$seqres.full 2>&1
+_scratch_mount >>$seqres.full 2>&1
+
+echo "Silence is golden"
+
+# fallocate(2) a 6G(> 4G) file on a 5G fs
+$XFS_IO_PROG -f -c "falloc 0 6g" $SCRATCH_MNT/testfile.$seq >>$seqres.full 2>&1
+
+_scratch_unmount
+_check_scratch_fs
+status=0
+exit
diff --git a/tests/generic/312.out b/tests/generic/312.out
new file mode 100644
index 0000000..6e72aa9
--- /dev/null
+++ b/tests/generic/312.out
@@ -0,0 +1,2 @@
+QA output created by 312
+Silence is golden
diff --git a/tests/generic/group b/tests/generic/group
index eb52833..cb15afe 100644
--- a/tests/generic/group
+++ b/tests/generic/group
@@ -114,3 +114,4 @@
 309 auto quick
 310 auto
 311 auto metadata log
+312 auto quick prealloc enospc
-- 
1.8.2.1

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

             reply	other threads:[~2013-05-06  9:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-06  9:42 Eryu Guan [this message]
2013-05-10  7:07 ` [PATCH v3] xfstests generic 312: test fallocate(2) ENOSPC when file size is greater than 4G Eryu Guan
2013-05-15 13:14 ` Rich Johnston
2013-05-15 13:16 ` Rich Johnston

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1367833355-14473-1-git-send-email-eguan@redhat.com \
    --to=eguan@redhat.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.