From: Yanmin Zhang <yanmin_zhang@linux.intel.com>
To: linasvepstas@gmail.com
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Zhang, LongX" <longx.zhang@intel.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Joseph.Liu@Emulex.Com" <Joseph.Liu@emulex.com>
Subject: Re: Subject : [ PATCH ] pci-reset-error_state-to-pci_channel_io_normal-at-report_slot_reset
Date: Tue, 07 May 2013 14:01:16 +0800 [thread overview]
Message-ID: <1367906476.2260.2.camel@ymzhang.sh.intel.com> (raw)
In-Reply-To: <CAHrUA34O=JEbmMSCmycNSXa1L6KXAWBCM5TfBOvzj_zSRMubHQ@mail.gmail.com>
On Fri, 2013-05-03 at 13:00 -0500, Linas Vepstas wrote:
> Greg,
>
> I've been receiving (and reading!) these messages; I replied that I am
> not maintaining a tree, and have no way of testing these patches (no
> access to hardware.) I believe it unlikely that my situation will
> change, and so I should probably be removed from the maintainers file.
>
> No acked-by or anything; the patches are not "obviously correct" by
> visual inspection; they may be right, but would require deeper
> thinking about what is actually happening than I'm capable of at this
> time; I'm a bit rusty with this code base, and might miss something
> important
powerpc uses the similar method. See function eeh_report_reset.
We worked out the patch after checking powerpc codes.
Joseph Liu helped test the patch and the patch does work well.
> .
>
> -- Linas
>
> p.s. you didn't see my earlier reply because I forgot to hit 'plain text reply'
>
>
> On 2 May 2013 22:13, Yanmin Zhang <yanmin_zhang@linux.intel.com> wrote:
> >
> > On Thu, 2013-05-02 at 19:00 -0700, Greg Kroah-Hartman wrote:
> > > On Fri, May 03, 2013 at 08:33:00AM +0800, Yanmin Zhang wrote:
> > > > On Wed, 2013-05-01 at 20:20 -0500, Linas Vepstas wrote:
> > > > > Hi,
> > > > >
> > > > > On 1 May 2013 19:30, Yanmin Zhang <yanmin_zhang@linux.intel.com>
> > > > > wrote:
> > > > > On Fri, 2013-04-26 at 06:28 +0000, Zhang, LongX wrote:
> > > > > > From: Zhang Long <longx.zhang@intel.com>
> > > > > >
> > > > > > Specific pci device drivers might have many functions to
> > > > > call
> > > > > > pci_channel_offline to check device states. When slot_reset
> > > > > happens,
> > > > > > drivers' slot_reset callback might call such functions and
> > > > > eventually
> > > > > > abort the reset.
> > > > > >
> > > > > > The patch resets pdev->error_state to pci_channel_io_normal
> > > > > at
> > > > > > the begining of report_slot_reset.
> > > > > >
> > > > > > Thank Liu Joseph for pointing it out.
> > > > >
> > > > > Linas, Bjorn,
> > > > >
> > > > > Would you like to merge the patch to your testing tree?
> > > > > The patch resolves one issue pointed out by Joseph.
> > > > >
> > > > >
> > > > > I'm not maintaining a tree at this time, and am not able to test.
> > > > > Sorry.
> > > > Thanks Linas.
> > > >
> > > > Greg,
> > > >
> > > > Would you like to merge it into your testing tree? Joseph Liu tested
> > > > the patch and it does work.
> > >
> > > You do know about the scripts/get_maintainer.pl script, right?
> > >
> > > Hint, try it out :)
> > Greg,
> >
> > Thanks. We did send to the right people, Linas and Bjorn.
> >
> > scripts/get_maintainer.pl 0001-pci-reset-error_state-to-pci_channel_io_normal-at-re.patch
> > Bjorn Helgaas <bhelgaas@google.com> (supporter:PCI SUBSYSTEM,commit_signer:7/8=88%,commit_signer:10/11=91%)
> > Linas Vepstas <linasvepstas@gmail.com> (commit_signer:2/8=25%)
> > Yijing Wang <wangyijing@huawei.com> (commit_signer:2/8=25%,commit_signer:2/11=18%)
> > Jiang Liu <jiang.liu@huawei.com> (commit_signer:2/8=25%,commit_signer:2/11=18%)
> > Stephen Hemminger <shemminger@vyatta.com> (commit_signer:1/8=12%)
> > "Rafael J. Wysocki" <rafael.j.wysocki@intel.com> (commit_signer:6/11=55%)
> > Huang Ying <ying.huang@intel.com> (commit_signer:5/11=45%)
> > linux-pci@vger.kernel.org (open list:PCI SUBSYSTEM)
> > linux-kernel@vger.kernel.org (open list)
> >
> >
> > I remember Jesse was maintaining PCI subsystem and he responded quickly.
> >
> > Yanmin
> >
> >
next prev parent reply other threads:[~2013-05-07 5:59 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-26 6:28 Subject : [ PATCH ] pci-reset-error_state-to-pci_channel_io_normal-at-report_slot_reset Zhang, LongX
2013-05-02 0:30 ` Yanmin Zhang
[not found] ` <CAHrUA34H_B-ffebx6ueHgV1ax-PL_3hLZr1JGaP2NJZ7bYgvtw@mail.gmail.com>
2013-05-03 0:33 ` Yanmin Zhang
2013-05-03 2:00 ` Greg Kroah-Hartman
2013-05-03 3:13 ` Yanmin Zhang
2013-05-03 18:00 ` Linas Vepstas
2013-05-07 6:01 ` Yanmin Zhang [this message]
2013-05-17 23:43 ` Bjorn Helgaas
2013-05-17 23:56 ` Rafael J. Wysocki
2013-05-20 17:21 ` Bjorn Helgaas
2013-05-20 17:52 ` Linas Vepstas
2013-05-20 14:38 ` Liu, Joseph
2013-05-20 15:37 ` Linas Vepstas
2013-05-21 7:49 ` Yanmin Zhang
2013-05-21 13:38 ` Linas Vepstas
2013-05-20 22:48 ` Bjorn Helgaas
2013-05-21 7:40 ` Yanmin Zhang
2013-05-21 16:17 ` Bjorn Helgaas
2013-05-21 15:41 ` Liu, Joseph
2013-05-21 16:26 ` Linas Vepstas
2013-05-21 16:51 ` Bjorn Helgaas
2013-06-04 18:04 ` Bjorn Helgaas
2013-06-05 0:38 ` Yanmin Zhang
2013-06-05 13:30 ` Bjorn Helgaas
2013-06-06 6:29 ` Yanmin Zhang
2013-06-10 17:24 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1367906476.2260.2.camel@ymzhang.sh.intel.com \
--to=yanmin_zhang@linux.intel.com \
--cc=Joseph.Liu@emulex.com \
--cc=bhelgaas@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=linasvepstas@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=longx.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.